Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update docs #89

Merged
merged 4 commits into from
Nov 12, 2021
Merged

update docs #89

merged 4 commits into from
Nov 12, 2021

Conversation

MegaByte875
Copy link
Contributor

No description provided.

Comment on lines 3 to 5
Scaling out Storage is divided into two stages. In the first stage, you need to wait for the status of all newly created Pods to be Ready.

In the second stage, the BALANCE DATA and BALANCE LEADER command is executed. We provide a parameter `enableAutoBalance` in crd to control whether to automatically balance data and leader.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjust the structure?

For example:

Scaling out Storage is ...

  • In the first stage, ...
  • In the second stage, ...

We provide ...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's need to update config/samples/apps_v1alpha1_nebulacluster.yaml file ? And helm charts?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will update the apps_v1alpha1_nebulacluster.yaml in another pr

Comment on lines 129 to 130
app: nginx-ingress
component: default-backend
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that the traffic will not go to graph?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'll remove it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's used to proxy nginx traffic, I think it's useless, we need not to connect it in kubernetes.

Comment on lines 3 to 5
Scaling out Storage is divided into two stages. In the first stage, you need to wait for the status of all newly created Pods to be Ready.

In the second stage, the BALANCE DATA and BALANCE LEADER command is executed. We provide a parameter `enableAutoBalance` in crd to control whether to automatically balance data and leader.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's need to update config/samples/apps_v1alpha1_nebulacluster.yaml file ? And helm charts?

Copy link
Contributor

@veezhang veezhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@veezhang veezhang merged commit 6304318 into vesoft-inc:master Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants