Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance logging #186

Merged
merged 3 commits into from
Dec 22, 2021
Merged

enhance logging #186

merged 3 commits into from
Dec 22, 2021

Conversation

HarrisChu
Copy link
Contributor

fixed #150
fixed #163

  1. remove basicConfig, it would rewrite user configs.
  2. use getLogger, could use multiple log level for users. e.g. debug level for root, and warning level for nebula2.
logging.getLogger('nebula2').setLevel(logging.DEBUG)

Copy link
Contributor

@Aiee Aiee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aiee Aiee merged commit 259b8f7 into vesoft-inc:master Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

建议移除logging.basicConfig too many logs are printed when calling GraphStorageClient.scan_vertex().
2 participants