Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unusable connection if connection Ping() failed #255

Merged
merged 2 commits into from
Jan 11, 2023

Conversation

Aiee
Copy link
Contributor

@Aiee Aiee commented Jan 11, 2023

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

Chery-pick some PR from 2.6.1 patch to the master branch

Remove unusable connection if connection Ping() failed

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

…vesoft-inc#247)

* rRemove unusable connection if connectino Ping() failed

* Fix typo
…c#251)

* Add more tests

* Tune tests and refactor

Lower concurrence for ci so the github action can pass
@Aiee Aiee requested review from HarrisChu and wey-gu January 11, 2023 08:52
@Aiee Aiee added the type/enhancement Type: make the code neat or more efficient label Jan 11, 2023
@Aiee Aiee merged commit 23bf01f into vesoft-inc:master Jan 11, 2023
@Aiee Aiee deleted the refactor-interface branch January 11, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Type: make the code neat or more efficient
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants