feat: Add get_prop_names methods for scan results #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haoxins
force-pushed
the
feat-add-prop-names
branch
from
04f1885
to
eb751e3
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #297 +/- ##
==========================================
- Coverage 77.88% 77.83% -0.05%
==========================================
Files 18 18
Lines 2419 2423 +4
==========================================
+ Hits 1884 1886 +2
- Misses 535 537 +2 ☔ View full report in Codecov by Sentry. |
Nicole00
previously approved these changes
Jan 5, 2024
|
Could you please check the ci for 3.12? |
|
@haoxins could you please help run |
wey-gu
previously approved these changes
Jan 5, 2024
haoxins
force-pushed
the
feat-add-prop-names
branch
from
8d7c578
to
c95af5d
Compare
|
can we drop support for |
I think it's fair(as of 2024 Jan) to drop py3.8. cc @Nicole00 We need to add this to the release note, but it's to me reasonable for now to support py3.9+ |
wey-gu
approved these changes
Jan 5, 2024
wey-gu
approved these changes
Jan 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description:
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc: