Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add thrift wrapper for meta and storage #31

Merged
merged 17 commits into from
Aug 31, 2020
Merged

add thrift wrapper for meta and storage #31

merged 17 commits into from
Aug 31, 2020

Conversation

jievince
Copy link
Contributor

@jievince jievince commented Aug 4, 2020

Add some thrift wrapper about reading vertexes, edges and meta information.
test on a 3-node cluster:
192.168.8.16 is meta server ip, 45500 is meta listening port, nba is the space name to read.
run example python3 GetFullGraph.py 192.168.8.16 45500 nba
result:

scaning space nba
ok
tagName:  player
vid:  109
{'name': 'Tiago Splitter', 'age': 34}
vid:  119
{'name': 'Kevin Durant', 'age': 30}
vid:  129
{'name': 'Dwyane Wade', 'age': 37}
vid:  139
{'name': 'Marc Gasol', 'age': 34}
vid:  149
{'name': 'Ben Simmons', 'age': 22}
tagName:  team
vid:  209
{'name': 'Timberwolves'}
vid:  219
{'name': '76ers'}
vid:  229
{'name': 'Heat'}
tagName:  player
vid:  108
{'name': 'Boris Diaw', 'age': 36}
vid:  118
{'name': 'Russell Westbrook', 'age': 30}
vid:  128
...

Copy link
Contributor

@laura-ding laura-ding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

Could you add some tests in tests dir?

nebula/ngMeta/MetaClient.py Outdated Show resolved Hide resolved
nebula/ngStorage/StorageClient.py Outdated Show resolved Hide resolved
nebula/ngMeta/MetaClient.py Outdated Show resolved Hide resolved
@jievince
Copy link
Contributor Author

jievince commented Aug 7, 2020

test_StorageClient.py failed.
docker-compose maps the metad listening port to a random port, but the test requires a fixed metad port to connect.

@jievince
Copy link
Contributor Author

examples/StorageClientExample.py Outdated Show resolved Hide resolved
nebula/ngMeta/MetaClient.py Outdated Show resolved Hide resolved
nebula/ngMeta/MetaClient.py Outdated Show resolved Hide resolved
nebula/ngData/data.py Outdated Show resolved Hide resolved
nebula/ngData/data.py Outdated Show resolved Hide resolved
examples/StorageClientExample.py Outdated Show resolved Hide resolved
nebula/ngMeta/MetaClient.py Outdated Show resolved Hide resolved
nebula/ngStorage/StorageClient.py Outdated Show resolved Hide resolved
nebula/ngData/data.py Outdated Show resolved Hide resolved
nebula/ngData/data.py Outdated Show resolved Hide resolved
nebula/ngData/data.py Outdated Show resolved Hide resolved
tests/test_StorageClient.py Outdated Show resolved Hide resolved
tests/test_StorageClient.py Outdated Show resolved Hide resolved
nebula/ngMeta/MetaClient.py Show resolved Hide resolved
nebula/ngMeta/MetaClient.py Outdated Show resolved Hide resolved
examples/StorageClientExample.py Outdated Show resolved Hide resolved
tests/test_StorageClient.py Show resolved Hide resolved
Copy link
Contributor

@laura-ding laura-ding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@laura-ding laura-ding merged commit b8774eb into vesoft-inc:master Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants