Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support delete related edges when delete vertex #53

Merged
merged 2 commits into from
Aug 17, 2022

Conversation

Nicole00
Copy link
Contributor

close #52

@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2022

Codecov Report

Merging #53 (30f284d) into master (afdb61d) will increase coverage by 0.22%.
The diff coverage is 75.67%.

@@             Coverage Diff              @@
##             master      #53      +/-   ##
============================================
+ Coverage     73.86%   74.09%   +0.22%     
- Complexity      152      153       +1     
============================================
  Files            24       24              
  Lines          1580     1594      +14     
  Branches        255      256       +1     
============================================
+ Hits           1167     1181      +14     
  Misses          266      266              
  Partials        147      147              
Impacted Files Coverage Δ
...t/nebula/connector/writer/NebulaVertexWriter.scala 71.42% <50.00%> (+0.69%) ⬆️
...esoft/nebula/connector/writer/NebulaExecutor.scala 60.69% <53.33%> (+0.39%) ⬆️
...ala/com/vesoft/nebula/connector/NebulaConfig.scala 79.17% <91.66%> (+0.37%) ⬆️
...la/com/vesoft/nebula/connector/NebulaOptions.scala 85.31% <100.00%> (+0.25%) ⬆️
...n/scala/com/vesoft/nebula/connector/Template.scala 100.00% <100.00%> (ø)
...in/scala/com/vesoft/nebula/connector/package.scala 59.47% <100.00%> (+0.21%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@jievince jievince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@jievince jievince merged commit f96b44f into vesoft-inc:master Aug 17, 2022
@Nicole00
Copy link
Contributor Author

Good job!

Thanks!

@MuYiYong
Copy link

The original requirement come from https://github.com/vesoft-inc/requirement-holder/issues/110

Nicole00 added a commit that referenced this pull request Aug 31, 2022
* pyspark example added (#51)

* pyspark example added

* Update README_CN.md

* support delete related edges when delete vertex (#53)

* support delete related edges when delete vertex

* add test

* add example for delete vertex with edge (#54)

* doc: pyspark write example (#55)

* doc: pyspark write example

* Added pyshell calling lines and python file header

discussed in #50
Thanks to @Reid00

* Update README.md

wording

* Update README_CN.md

* Update README.md

* Update README_CN.md

* Update README.md

* Update README_CN.md

* spark2.2 reader initial commit

* spark2.2 reader initial commit

* extract common config for multi spark version

* delete common config files

* extract common config and utils

* remove common test

* spark connector reader for spark 2.2

* spark connector writer for spark 2.2

* revert example

* refactor spark version & close metaProvider after finish writing

* refactor common package name

* fix scan part

* refactor spark version for spark2.2

* connector writer for spark2.2

Co-authored-by: Wey Gu <weyl.gu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support delete the related edges when delete vertex
4 participants