Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

throw error for failed use space execution #63

Merged
merged 3 commits into from
Oct 24, 2022

Conversation

Nicole00
Copy link
Contributor

No description provided.

@@ -30,7 +30,7 @@ class GraphProviderTest extends AnyFunSuite with BeforeAndAfterAll {
}

test("switchSpace") {
assert(!graphProvider.switchSpace("root", "nebula", "not_exit_space"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about?

-not_exit_space
+space_not_exist

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, changed the space name

@codecov-commenter
Copy link

Codecov Report

Base: 74.09% // Head: 50.72% // Decreases project coverage by -23.36% ⚠️

Coverage data is based on head (855f8b4) compared to base (f78db4c).
Patch coverage: 80.46% of modified lines in pull request are covered.

❗ Current head 855f8b4 differs from pull request most recent head a08bdb0. Consider uploading reports for the commit a08bdb0 to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##             master      #63       +/-   ##
=============================================
- Coverage     74.09%   50.72%   -23.37%     
+ Complexity      153      122       -31     
=============================================
  Files            24       26        +2     
  Lines          1594     1451      -143     
  Branches        256      240       -16     
=============================================
- Hits           1181      736      -445     
- Misses          266      639      +373     
+ Partials        147       76       -71     
Impacted Files Coverage Δ
...ala/com/vesoft/nebula/connector/NebulaConfig.scala 56.89% <ø> (ø)
...scala/com/vesoft/nebula/connector/NebulaEnum.scala 78.57% <ø> (ø)
...la/com/vesoft/nebula/connector/NebulaOptions.scala 0.00% <ø> (ø)
...cala/com/vesoft/nebula/connector/NebulaUtils.scala 59.70% <ø> (ø)
...a/com/vesoft/nebula/connector/PartitionUtils.scala 100.00% <ø> (ø)
...n/scala/com/vesoft/nebula/connector/Template.scala 0.00% <ø> (ø)
.../vesoft/nebula/connector/exception/Exception.scala 0.00% <ø> (ø)
...cala/com/vesoft/nebula/connector/ssl/SSLEnum.scala 100.00% <ø> (ø)
...om/vesoft/nebula/connector/ssl/SSLSignParams.scala 0.00% <ø> (ø)
...esoft/nebula/connector/writer/NebulaExecutor.scala 0.00% <ø> (ø)
... and 24 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Nicole00 Nicole00 merged commit 44015bb into vesoft-inc:master Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants