Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi bare metal #25

Merged
merged 5 commits into from
Jul 6, 2021
Merged

Conversation

veezhang
Copy link
Contributor

@veezhang veezhang commented Jun 17, 2021

This pr is base on #24
Feature: #23

  • add cluster metrics for bare metal
  • config file optimization
  • grafana config
  • helm charts adjustment
  • docs[en, cn] Fix: README/Doc in EN #19

@veezhang veezhang added the type/enhancement New feature or request label Jun 17, 2021
@CLAassistant
Copy link

CLAassistant commented Jun 17, 2021

CLA assistant check
All committers have signed the CLA.

@veezhang veezhang force-pushed the multi-bare-metal branch 2 times, most recently from a4c3202 to aa3e7bf Compare June 21, 2021 07:48
@veezhang veezhang mentioned this pull request Jun 21, 2021
@veezhang veezhang mentioned this pull request Jun 22, 2021
MegaByte875
MegaByte875 previously approved these changes Jun 24, 2021
$ kubectl delete crd servicemonitors.monitoring.coreos.com
$ kubectl delete crd thanosrulers.monitoring.coreos.com
$ kubectl delete ns monitoring example1 example1
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put these cmds into a shell script then execute once ?

Copy link
Contributor Author

@veezhang veezhang Jul 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shell script file ? Or shell command in markdown?
If necessary, merge those command later.

$ kubectl -n monitoring port-forward svc/prometheus-grafana 3000:80
```

Grafana 的默认 `用户名/密码` 是 `admin/prom-operator`, http 地址是 `http://127.0.0.1:3000`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

admin/admin

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The password for kube-prometheus-stack is prom-operator.

scrape_configs:
- job_name: 'nebula-stats-exporter'
static_configs:
- targets: ['<<NEBULA_STATS_EXPORTER_HOSTNAME>>:9100'] # nebula-stats-exporter metrics endpoints
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A hostname or ip followed by an optional port

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If add a placeholder to the port, will it be too complicated?

Comment on lines 102 to 103
| `podLabels` | Nebula stats exporter pod labels | `{}` |
| `podLabels` | Nebula stats exporter resources | `{}` |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

repetitive filed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed

Comment on lines +105 to +107
| `nodeSelector` | Nebula stats exporter nodeSelector | `{}` |
| `tolerations` | Nebula stats exporter tolerations | `{}` |
| `affinity` | Nebula stats exporter affinity | `{}` |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add more description relate k8s to make it clearly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those who use operator should know the probabilities related to kubernetes. Do we need to reiterate it?

Copy link
Contributor

@MegaByte875 MegaByte875 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

README/Doc in EN
3 participants