This repository has been archived by the owner on Dec 1, 2022. It is now read-only.
PlainTable support #358
Merged
PlainTable support #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
critical27
requested review from
liuyu85cn,
bright-starry-sky and
panda-sheep
| @@ -114,6 +125,8 @@ RocksEngine::RocksEngine(GraphSpaceID spaceId, | |||
| db_.reset(db); | |||
| partsNum_ = allParts().size(); | |||
| LOG(INFO) << "open rocksdb on " << path; | |||
|
|
|||
| backup(); | |||
There was a problem hiding this comment.
A little confused, seems like a run for nothing, could give some comments?
There was a problem hiding this comment.
Long story, I can't remember very clear.
- If we don't backup here, we write some data, and storage is stopped before we do a valid backup.
- Mock machine reboot, so rocksdb data in memory is lost. (rocksdb wal is persisted in disk, so we could recover from it in theory)
- Restart the storage, rocks db will be failed to open, log is
While creating a new Db, wal_dir contains existing log file: ....
I believe the problem is that if we backup here, it is not nothing here. Something like CURRENT and MANIFEST will be backuped. In that way, rocksdb will think the wal is legal.
It involves some rocksdb code, so complicated. Then I try this way and it works.
There was a problem hiding this comment.
I see. It's a very complicated story.
critical27
force-pushed
the
plain
branch
2 times, most recently
from
f12720e
to
3c59a05
Compare
|
|
bright-starry-sky
previously approved these changes
Mar 30, 2021
critical27
force-pushed
the
plain
branch
3 times, most recently
from
28d9d53
to
0375814
Compare
critical27
requested review from
bright-starry-sky,
darionyaphet and
linkensphere201
panda-sheep
approved these changes
Jun 23, 2021
This was referenced Jun 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support rocksdb PlainTable and nebula work in memory