This repository has been archived by the owner on Dec 1, 2022. It is now read-only.
Fix show stats #519
Merged
Fix show stats #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
critical27
requested review from
darionyaphet,
linkensphere201,
cangfengzhs,
liuyu85cn,
bright-starry-sky and
panda-sheep
panda-sheep
reviewed
Jul 8, 2021
| @@ -234,7 +233,6 @@ RocksEngine::rangeWithPrefix(const std::string& start, | |||
| const std::string& prefix, | |||
| std::unique_ptr<KVIterator>* storageIter) { | |||
| rocksdb::ReadOptions options; | |||
| options.prefix_same_as_start = true; | |||
There was a problem hiding this comment.
Good job，thx
Perhaps just removing prefix_same_as_start is enough. In this way rocksdb uses the default value of prefix_same_as_start.
liuyu85cn
previously approved these changes
Jul 9, 2021
|
Hold on a sec, do some research. It is so complicated. |
critical27
dismissed stale reviews from bright-starry-sky and liuyu85cn
via
3a1832c
|
Ready.... |
bright-starry-sky
approved these changes
Jul 12, 2021
liuyu85cn
approved these changes
Jul 12, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both BlockBasedTable and PlainTable will failed in some certain case.
prefix_same_as_start, it is ok to remove it since we check it externally.Will dig more later and add some test case.