This repository has been archived by the owner on Dec 1, 2022. It is now read-only.
Re-change the options for rebuild index batch number #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randomJoe211
previously approved these changes
Aug 5, 2021
|
Hold on for one sec. |
|
I discussed it with @critical27 , |
critical27
reviewed
Aug 5, 2021
src/storage/StorageFlags.cpp
Outdated
| @@ -26,6 +26,9 @@ DEFINE_int32(rebuild_index_batch_num, 256, | |||
| DEFINE_int32(rebuild_index_locked_threshold, 256, | |||
| "The locked threshold will refuse writing."); | |||
|
|
|||
| DEFINE_int32(rebuild_index_process_interval, 30000, | |||
There was a problem hiding this comment.
3ms is enough I think? 30ms means there are 33 request at most for one second.
There was a problem hiding this comment.
3ms is enough I think? 30ms means there are 33 request at most for one second.
good catch. fixed.
darionyaphet
approved these changes
Aug 9, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm so sorry. the configuration file was wrong in the previous PR #540. Let's correct that in this PR.
馃槄