feat: middleware #208
Merged
feat: middleware #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nianiaJR
reviewed
May 11, 2022
veezhang
reviewed
May 11, 2022
Comment on lines
10
to
18
| "github.com/golang-jwt/jwt/v4" | ||
| "github.com/vesoft-inc/nebula-http-gateway/ccore/nebula/gateway/dao" | ||
| "github.com/vesoft-inc/nebula-http-gateway/ccore/nebula/gateway/pool" | ||
| "github.com/vesoft-inc/nebula-studio/server/api/studio/internal/config" | ||
| "github.com/vesoft-inc/nebula-studio/server/api/studio/internal/types" | ||
| "github.com/vesoft-inc/nebula-studio/server/api/studio/pkg/ecode" | ||
| "github.com/vesoft-inc/nebula-studio/server/api/studio/pkg/utils" | ||
| "github.com/zeromicro/go-zero/rest" | ||
| "github.com/zeromicro/go-zero/rest/httpx" |
There was a problem hiding this comment.
import with sort? you can make check.
| @@ -0,0 +1,100 @@ | |||
| package middleware | |||
| defer server.Stop() | ||
|
|
||
| // global middleware | ||
| // server.Use(auth.AuthMiddleware) | ||
| server.Use(auth.AuthMiddlewareWithConfig(&c)) | ||
|
|
||
| // static assets handlers | ||
| utils.RegisterHandlers(server, svcCtx, embedAssets) |
There was a problem hiding this comment.
So, utils.RegisterHandlers is no longer needed, can it be deleted?
|
|
veezhang
reviewed
May 11, 2022
|
|
||
| svcCtx := svc.NewServiceContext(c) | ||
| server := rest.MustNewServer(c.RestConf, rest.WithNotFoundHandler(middleware.NewAssertsHandler(middleware.AssertsConfig{ | ||
| Root: "assets", |
There was a problem hiding this comment.
If you configure the Filesystem, the Root is need not.
nianiaJR
reviewed
May 11, 2022
| @@ -6,6 +6,6 @@ Debug: | |||
| Enable: false | |||
| Auth: | |||
| AccessSecret: "login_secret" | |||
There was a problem hiding this comment.
using a more strict random string?
nianiaJR
reviewed
May 11, 2022
| return &types.ConnectDBResult{ | ||
| Version: string(clientInfo.NebulaVersion), | ||
| Version: string(request.NebulaVersion), |
There was a problem hiding this comment.
so where you real make the db connection? logics seems to be delete above?
nianiaJR
reviewed
May 11, 2022
| Value: clientInfo.ClientID, | ||
| Path: "/", | ||
| HttpOnly: true, | ||
| MaxAge: 1800, |
There was a problem hiding this comment.
read from the config? just make it configurable
nianiaJR
reviewed
May 11, 2022
| MaxAge: 1800, | ||
| } | ||
| nsid := http.Cookie{ | ||
| Name: "nsid", |
There was a problem hiding this comment.
In order to make the nsid conflict with other apps, you'd better make it configuarable and add a prefix like explorer-nsid. So same is the cookie field token
nianiaJR
reviewed
May 11, 2022
Comment on lines
122
to
123
| w.Header().Set("Set-Cookie", token.String()) | ||
| w.Header().Add("Set-Cookie", nsid.String()) |
There was a problem hiding this comment.
Are these fileds http-only?
nianiaJR
reviewed
May 11, 2022
hetao92
pushed a commit
that referenced
this pull request
May 26, 2022
* feat: middleware * feat: dynamicly add query params func * feat: common params * update: go mod tidy * feat: batchExec
hetao92
pushed a commit
that referenced
this pull request
May 26, 2022
feat: mime && connectdb store u 文件上传、删除、预览功能实现 (#206) feat: middleware (#208) * feat: middleware * feat: dynamicly add query params func * feat: common params * update: go mod tidy * feat: batchExec complete file and import task (#213) modify upload and download mody: go mod refine the code update: make check modify return values Refactor (#219) * update: server-v2 * updata: format feat: context auth (#220) update: export module (#222) feat: export RegisterHandlers (#223) update: gitignore (#224) fix: fix service init crash (#225) update: WithErrorMessage (#226) fix import task (#227) fix the type conveersion problem fix: fix import & file model (#229)
huaxiabuluo
added a commit
that referenced
this pull request
May 26, 2022
feat: mime && connectdb feat: 文件上传、删除、预览功能实现 (#206) feat: middleware (#208) * feat: middleware * feat: dynamicly add query params func * feat: common params * update: go mod tidy * feat: batchExec complete file and import task (#213) modify upload and download mody: go mod refine the code update: make check modify return values Refactor (#219) * update: server-v2 * updata: format feat: context auth (#220) update: export module (#222) feat: export RegisterHandlers (#223) update: gitignore (#224) fix: fix service init crash (#225) update: WithErrorMessage (#226) fix import task (#227) fix the type conveersion problem fix: fix import & file model (#229) Co-authored-by: Bruce <bruce.lu@vesoft.com>
veeding
pushed a commit
to veeding/nebula-studio
that referenced
this pull request
Jun 14, 2022
* feat: middleware * feat: dynamicly add query params func * feat: common params * update: go mod tidy * feat: batchExec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.