add goroutine to update taskinfo #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
veezhang
reviewed
Jun 14, 2022
| go func() { | ||
| for { | ||
| select { | ||
| case <-time.After(100 * time.Millisecond): |
There was a problem hiding this comment.
It might be better to use time.Ticker?
There was a problem hiding this comment.
And it's need to update every 100 millisecond ?
| } | ||
| result.Total = int64(len(result.List)) |
There was a problem hiding this comment.
I thank it is not the total of record in db.
veezhang
reviewed
Jun 14, 2022
| @@ -93,6 +93,21 @@ func Import(taskID string, conf *importconfig.YAMLConfig) (err error) { | |||
| } | |||
|
|
|||
| task, _ := GetTaskMgr().GetTask(taskID) | |||
| signal := make(chan struct{}, 1) | |||
| go func() { | |||
| ticker := time.NewTicker(2 * time.Second) | |||
Comment on lines
50
to
54
| tx := t.Model(&TaskInfo{}).Where("nebula_address = ? And user = ?", nebulaAddress, user) | ||
| tx.Count(&count) | ||
| if err := tx.Offset((pageIndex - 1) * pageSize).Limit(pageSize).Find(&tasks).Error; err != nil { |
fix fix fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solve issue228