fix: clear store #405
Merged
fix: clear store #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huaxiabuluo
reviewed
Dec 21, 2022
| @@ -16,7 +16,7 @@ const FileUpload = () => { | |||
| const [loading, setLoading] = useState(false); | |||
| const transformFile = async (_file: StudioFile, fileList: StudioFile[]) => { | |||
| const size = fileList.reduce((acc, cur) => acc + cur.size, 0); | |||
| if(size > global.gConfig.maxBytes) { | |||
| if(global.gConfig.maxBytes && size > global.gConfig.maxBytes) { | |||
There was a problem hiding this comment.
what's the maxBytes default value if config item is empty ?
There was a problem hiding this comment.
I think there is no need to execute this logic if it is not set or it is not read for some reason, it is better to report 413 directly
There was a problem hiding this comment.
there is default value for maxBytes config, not setting doesn't mean it not work, see the doc below and make tests
https://go-zero.dev/docs/configuration/api?_highlight=maxbytes#restrestconf
There was a problem hiding this comment.
go-zero@1.3.3
RestConf struct {
service.ServiceConf
Host string `json:",default=0.0.0.0"`
Port int
CertFile string `json:",optional"`
KeyFile string `json:",optional"`
Verbose bool `json:",optional"`
MaxConns int `json:",default=10000"`
MaxBytes int64 `json:",default=1048576"`
// milliseconds
Timeout int64 `json:",default=3000"`
CpuThreshold int64 `json:",default=900,range=[0:1000]"`
Signature SignatureConf `json:",optional"`
}There was a problem hiding this comment.
Can't read the default value
mod: code review mod: code review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description:
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc: