Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update en-US.json #58

Merged
merged 1 commit into from
Dec 8, 2021
Merged

Update en-US.json #58

merged 1 commit into from
Dec 8, 2021

Conversation

wey-gu
Copy link
Contributor

@wey-gu wey-gu commented Dec 8, 2021

Trying to improve some i18n, still need further work.

Trying to improve some i18n, still need further work.
Copy link
Contributor

@hetao92 hetao92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hetao92 hetao92 merged commit 3da6021 into master Dec 8, 2021
@hetao92 hetao92 deleted the wey-gu-patch-i18n branch December 8, 2021 08:38
@@ -30,7 +30,7 @@
"feedback": "Feedback",
"forum": "Help Forum",
"forumLink": "https://discuss.nebula-graph.io/",
"ask": "Sure to do this?",
"ask": "Are you sure to proceed?",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

---> Are you sure you want to proceed?
Are you sure to do means do you ensure the action(to do) instead of what you intend.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @abby-cyber, I think need your expertise to help review/revisit all i18n fields of the studio, I was just trying to do some of them(in the wrong way as you help pointed here ;-) ), would you mind helping when you have the bandwidth to do so?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, sure

},
"explore": {
"clear": "Clear",
"clearTip": "Whether to clear the graph,are you sure?",
"clearTip": "Are you sure to proceed the cleanup of the renderred graph view?",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

"outgoing": "Outgoing",
"incoming": "Incoming",
"bidirect": "Bidirect",
"filter": "Custom filter conditions",
"operator": "Operator",
"value": "Value",
"selectSpace": "Please select the space",
"selectReminder": "This will clear the existed graph, are you sure?",
"selectReminder": "The selection of space will cleanup the renderred graph view, are you sure to proceed?",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

"insertMethodSelect": "Some data on the board. Please select how to insert the new queried results",
"incrementalInsertion": "Incremental Insertion",
"insertAfterClear": "Insert After Clear",
"insertMethodSelect": "How do you like to render the new data with the existing graph view, incrementally or wipe the graph view first?",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"incrementally or wipe the graph view first" sounds a little bit strange here.

do you want to say render incrementally or xxx?

@wey-gu wey-gu mentioned this pull request Dec 9, 2021
"table": "Table",
"log": "Log",
"record": "Record",
"sorryNGQLCannotBeEmpty": "Sorry, nGQL cannot be empty",
"disablesUseToSwitchSpace": "Disables the use of commands to switch Space",
"NGQLHistoryList": "nGQL History List",
"disablesUseToSwitchSpace": "Switching space from console is not allowed by current role",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switching space from the Console is not allowed by the current role.

@@ -229,7 +229,7 @@
"next": "Next",
"goback": "Prev",
"mountPath": "Mount Path",
"importConfigValidationSuccess": "The config validation was successful",
"importConfigValidationSuccess": "The configuration validation was successful",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add . at the end of the sentence

@abby-cyber
Copy link

  1. It's better for us to unify the plural form of the word vertex. Vertices is preferred.
  2. For sentences, we need to add a period at the end of the sentence.

@wey-gu
Copy link
Contributor Author

wey-gu commented Dec 9, 2021

Thank you @abby-cyber , this pr was merged before your comments, allow me to move your comments into a new trackable place an issue: #59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants