Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update workflow with go-server #90

Merged
merged 1 commit into from
Jan 12, 2022
Merged

Conversation

hetao92
Copy link
Contributor

@hetao92 hetao92 commented Jan 12, 2022

No description provided.

Dockerfile Outdated
COPY ./app/assets/index.html /nebula-graph-studio/app/assets/
ENV NODE_OPTIONS=--max_old_space_size=2048
RUN npm run build
RUN ls && ls dist
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is debug command, you can remove it.

ExecStart=PREFIX_TEMPLATE/nebula-graph-studio/nebula-studio-server

[Install]
WantedBy=multi-user.target
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's it used for?

nianiaJR
nianiaJR previously approved these changes Jan 12, 2022
Copy link
Contributor

@nianiaJR nianiaJR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mod: update

mod: code review

mod: rename binary file
Copy link
Contributor

@nianiaJR nianiaJR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants