add gflags to control max_edge_returned_per_vertex #1221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unit testing failed. |
|
Unit testing passed. |
dangleptr
reviewed
Nov 7, 2019
src/storage/test/QueryBoundTest.cpp
Outdated
| @@ -225,7 +225,9 @@ TEST(QueryBoundTest, OutBoundSimpleTest) { | |||
| checkResponse(resp, 30, 12, 10001, 7, true); | |||
| } | |||
|
|
|||
| TEST(QueryBoundTest, inBoundSimpleTest) { | |||
| TEST(QueryBoundTest, MaxEdgesReturenedTest) { | |||
There was a problem hiding this comment.
Don't change the original UT, add a new one.
CPWstatic
reviewed
Nov 7, 2019
src/storage/QueryBaseProcessor.cpp
Outdated
| @@ -8,6 +8,7 @@ | |||
|
|
|||
| DEFINE_int32(max_handlers_per_req, 10, "The max handlers used to handle one request"); | |||
| DEFINE_int32(min_vertices_per_bucket, 3, "The min vertices number in one bucket"); | |||
| DEFINE_int32(max_edge_returned_per_vertex, 1000, "The max edge number returnred searching vertex"); | |||
There was a problem hiding this comment.
The default value should be a bigger one, I'd like it is the maximum of int32. That means we will not cut-off anything by default. And users would config it with an appropriate value in config-file, such as 1000 or 5000, etc.
There was a problem hiding this comment.
thx, change to INT_MAX
|
Unit testing passed. |
|
Unit testing passed. |
darionyaphet
approved these changes
Nov 8, 2019
|
Unit testing failed. |
|
Jenkins go |
|
Unit testing passed. |
whitewum
pushed a commit
to whitewum/nebula
that referenced
this pull request
Nov 11, 2019
* add gflags to control max edge returned from one vertex * rename gflags * fix logic error, from max vertice to max edge * while add new UT, replace an old one by mistake... fix it * change default max edge to INT_MAX
whitewum
added a commit
to whitewum/nebula
that referenced
this pull request
Nov 11, 2019
…og-doc * 'glog-doc' of https://github.com/whitewum/nebula: add gflags to control max_edge_returned_per_vertex (vesoft-inc#1221) Fix failed SchemaTest (vesoft-inc#1242) Support to create hard link for current WAL (vesoft-inc#1227) Clear the code associated with AddHosts/RemoveHosts (vesoft-inc#1172) add glog chs
tong-hao
pushed a commit
to tong-hao/nebula
that referenced
this pull request
Jun 1, 2021
* add gflags to control max edge returned from one vertex * rename gflags * fix logic error, from max vertice to max edge * while add new UT, replace an old one by mistake... fix it * change default max edge to INT_MAX
yixinglu
pushed a commit
to yixinglu/nebula
that referenced
this pull request
Jan 31, 2023
* doc: add users and cases, optimize format * doc: add users and cases, optimize format for Chinese README Co-authored-by: TommyLemon <tommy.zhou@vesoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.