Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There seems to be no newline when returning JSON format #2676

Open
cooper-lzy opened this issue Mar 4, 2021 · 4 comments
Open

There seems to be no newline when returning JSON format #2676

cooper-lzy opened this issue Mar 4, 2021 · 4 comments
Labels
good first issue Community: perfect as the first pull request type/enhancement Type: make the code neat or more efficient

Comments

@cooper-lzy
Copy link
Contributor

image
@CPWstatic CPWstatic transferred this issue from vesoft-inc/nebula-graph Aug 28, 2021
@CPWstatic CPWstatic added type/enhancement Type: make the code neat or more efficient good first issue Community: perfect as the first pull request labels Aug 28, 2021
@Abbas-Hussain-Muzammil
Copy link

Hey, Can you elaborate on the issue?

@PrahladPawar1733
Copy link

Hey, I am very new to open source and want to learn how to contribute.

@wey-gu
Copy link
Contributor

wey-gu commented Nov 28, 2022

Welcome to the nebulagraph community!

Feel free to take this task and as questions on it when needed :)

@mahajanhrishikesh
Copy link

mahajanhrishikesh commented Dec 17, 2022 •
edited
Loading

image
Would changing line 61 here from
std::string body = returnJson_ ? folly::toPrettyJson(vals) : toStr(vals);
to
std::string body = returnJson_ ? std::strcat(folly::toPrettyJson(vals), "\n") : toStr(vals);

help in solving this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Community: perfect as the first pull request type/enhancement Type: make the code neat or more efficient
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@wey-gu @CPWstatic @mahajanhrishikesh @cooper-lzy @PrahladPawar1733 @Abbas-Hussain-Muzammil