Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[STO]optimize job: Show job by space; Control the privilege when using “show all”; #2815

Closed
Sophie-Xie opened this issue Sep 8, 2021 · 3 comments · Fixed by #2872
Closed

[STO]optimize job: Show job by space; Control the privilege when using “show all”; #2815

Sophie-Xie opened this issue Sep 8, 2021 · 3 comments · Fixed by #2872
Assignees
@critical27 @SuperYoko
Labels
type/enhancement Type: make the code neat or more efficient
Projects
Nebula Graph Core v2.6.0
Milestone
v2.6.0

Comments

@Sophie-Xie
Copy link
Contributor

No description provided.

@Sophie-Xie Sophie-Xie added the type/enhancement Type: make the code neat or more efficient label Sep 8, 2021
@Sophie-Xie Sophie-Xie added this to the v2.6.0 milestone Sep 8, 2021
@Sophie-Xie Sophie-Xie added this to To Do in Nebula Graph Core v2.6.0 via automation Sep 8, 2021
@Sophie-Xie Sophie-Xie changed the title [QE]optimize job: Show job by space; Control the privilege when using “show all”; [STO]optimize job: Show job by space; Control the privilege when using “show all”; Sep 8, 2021
@critical27
Copy link
Contributor

After some discuss, we will change the default behavior of show jobs to only print space related jobs.
And show all is useless (we don't have a job which can touch multiple space), we won't support it.

@critical27 critical27 assigned critical27 and unassigned critical27 Sep 9, 2021
@SuperYoko SuperYoko self-assigned this Sep 9, 2021
@jamieliu1023 jamieliu1023 mentioned this issue Sep 11, 2021
Closed
@SuperYoko SuperYoko moved this from To Do to Coding in Nebula Graph Core v2.6.0 Sep 14, 2021
@panda-sheep
Copy link
Contributor

panda-sheep commented Sep 16, 2021 •
edited

Do stop job and recover job also need to be in the space?
All behaviors of job should be unified.@liuyu85cn @critical27

@liuyu85cn
Copy link
Contributor

Agree

@SuperYoko SuperYoko linked a pull request Sep 17, 2021 that will close this issue
Enhancement: "show jobs" only show space related #2872
Merged
@SuperYoko SuperYoko moved this from Coding to Code Review in Nebula Graph Core v2.6.0 Sep 18, 2021
Nebula Graph Core v2.6.0 automation moved this from Review in progress to Done Sep 24, 2021
yixinglu pushed a commit that referenced this issue Sep 24, 2021
@SuperYoko @critical27
Enhancement: "show jobs" only show space related (#2872)
3941945 
* Enhancement:change "show jobs" behavior to only print space related jobs.(#2815)

* show jobs will still remove all space expired jobs
* you will need choose one spaces before show job(s)

* FixReview: handle "stop job"&"recover job"
* only can stop jobs in chosen space
* only recover jobs in chosen space

* Fix&Add tck

* Fix review & format

Co-authored-by: Doodle <13706157+critical27@users.noreply.github.com>
This was referenced Oct 20, 2021
Closed
Closed
Closed
@nianiaJR nianiaJR mentioned this issue Oct 27, 2021
Closed
yixinglu pushed a commit to yixinglu/nebula that referenced this issue Mar 21, 2022
@nebula-bots @SuperYoko
Enhancement: "show jobs" only show space related (vesoft-inc#108)
178cec8 
* Enhancement:change "show jobs" behavior to only print space related jobs.(vesoft-inc#2815)

* show jobs will still remove all space expired jobs
* you will need choose one spaces before show job(s)

* FixReview: handle "stop job"&"recover job" * only can stop jobs in chosen space * only recover jobs in chosen space

* Fix&Add tck

* Fix review & format

Co-authored-by: SuperYoko <90179377+SuperYoko@users.noreply.github.com>
yixinglu pushed a commit to yixinglu/nebula that referenced this issue Sep 14, 2023
@Sophie-Xie @critical27
cherry pick from nebula: fix cluster id is not backuped (vesoft-inc#5573
a832d57 
) (vesoft-inc#2815)

fix cluster id is not backuped (vesoft-inc#5573)

Co-authored-by: Doodle <13706157+critical27@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@critical27 critical27

@SuperYoko SuperYoko

Labels
type/enhancement Type: make the code neat or more efficient
Projects
No open projects
Nebula Graph Core v2.6.0
  
Done
Milestone
v2.6.0
Development

Successfully merging a pull request may close this issue.

Enhancement: "show jobs" only show space related SuperYoko/nebula
5 participants
@critical27 @liuyu85cn @panda-sheep @Sophie-Xie @SuperYoko