Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad forward compatibility to rocksdb #2918

Closed
wenhaocs opened this issue Sep 24, 2021 · 4 comments · Fixed by #2920
Closed

Bad forward compatibility to rocksdb #2918

wenhaocs opened this issue Sep 24, 2021 · 4 comments · Fixed by #2920
Assignees
Labels
type/bug Type: something is unexpected
Milestone

Comments

@wenhaocs
Copy link
Contributor

The master RocksDB has a new enum CompactionReason: kChangeTemperature. If we compile the current nebula code with master rocksdb, it has a warning of not handling kChangeTemperature, and warnings are treated as errors.

@Shylock-Hg
Copy link
Contributor

Why don't compile with the rocksdb in thrid-party?

@wenhaocs
Copy link
Contributor Author

Why don't compile with the rocksdb in thrid-party?

For testing purpose. Need to use new features not existing in the version which nebula is using. In addition, the previous code was not a good practice anyway.

@Shylock-Hg
Copy link
Contributor

Why don't compile with the rocksdb in thrid-party?

For testing purpose. Need to use new features not existing in the version which nebula is using. In addition, the previous code was not a good practice anyway.

This force to handle each enumerate instead of return unknown directly.

@wenhaocs
Copy link
Contributor Author

Why don't compile with the rocksdb in thrid-party?

For testing purpose. Need to use new features not existing in the version which nebula is using. In addition, the previous code was not a good practice anyway.

This force to handle each enumerate instead of return unknown directly.

I am trying to follow the original logic, where it does return unknown if there is no match. In addition, other functions in the file are doing the same, like flushReasonString, backgroundErrorReasonString, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Type: something is unexpected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants