Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix forward compatibility issue when compiling with master rocksdb #2920

Merged
merged 3 commits into from
Sep 24, 2021

Conversation

wenhaocs
Copy link
Contributor

fix #2918

@wenhaocs wenhaocs requested a review from a team September 24, 2021 03:20
@wenhaocs wenhaocs added the ready-for-testing PR: ready for the CI test label Sep 24, 2021
@wenhaocs wenhaocs added this to the v2.6.0 milestone Sep 24, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #2920 (7eb29f0) into master (fd2e949) will increase coverage by 0.04%.
The diff coverage is 89.18%.

❗ Current head 7eb29f0 differs from pull request most recent head 127a71b. Consider uploading reports for the commit 127a71b to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2920      +/-   ##
==========================================
+ Coverage   85.45%   85.49%   +0.04%     
==========================================
  Files        1225     1225              
  Lines      109855   109937      +82     
==========================================
+ Hits        93872    93990     +118     
+ Misses      15983    15947      -36     
Impacted Files Coverage Δ
src/kvstore/EventListener.h 32.22% <0.00%> (-0.19%) ⬇️
src/meta/processors/job/JobDescription.h 100.00% <ø> (ø)
src/meta/processors/job/JobManager.h 100.00% <ø> (ø)
src/mock/AdHocSchemaManager.cpp 56.95% <0.00%> (-0.38%) ⬇️
src/meta/processors/job/AdminJobProcessor.cpp 65.11% <62.50%> (ø)
src/common/function/test/FunctionManagerTest.cpp 98.78% <63.63%> (-0.20%) ⬇️
src/meta/processors/job/JobManager.cpp 74.80% <95.23%> (+0.07%) ⬆️
src/clients/meta/MetaClient.cpp 74.78% <100.00%> (+0.30%) ⬆️
src/common/time/TimeUtils.cpp 92.59% <100.00%> (+8.59%) ⬆️
src/graph/validator/AdminJobValidator.cpp 93.75% <100.00%> (+0.20%) ⬆️
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fa47a4...127a71b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad forward compatibility to rocksdb
5 participants