Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A Java keyword is incorrectly defined as a variable name. #74

Closed
boshengchen opened this issue Jan 10, 2019 · 2 comments
Closed

A Java keyword is incorrectly defined as a variable name. #74

boshengchen opened this issue Jan 10, 2019 · 2 comments
Labels
type/enhancement Type: make the code neat or more efficient

Comments

@boshengchen
Copy link
Contributor

Describe the bug(must be provided)
A Java keyword is mistaken for a variable name, leads to a compilation error of the Java client interface. In line 57 of file graph.thrift.
Additional context
Source code :
union ColumnValue {
// Simple types
1: bool boolean,
.......
}
Generated code:
public static ColumnValue boolean(boolean value) {
ColumnValue x = new ColumnValue();
x.setBoolean(value);
return x;
}

@dangleptr
Copy link
Contributor

Indeed! Do you want to give a patch, @boshengchen :)

@dangleptr dangleptr added the type/enhancement Type: make the code neat or more efficient label Jan 10, 2019
@boshengchen
Copy link
Contributor Author

Sure! PR will be available later .

dutor pushed a commit that referenced this issue Jan 14, 2019
* fixed issue #74 of keyword error

* change var name from bool_flag to bool_val
@dutor dutor closed this as completed Jan 14, 2019
yixinglu pushed a commit to yixinglu/nebula that referenced this issue Feb 16, 2020
* fixed issue vesoft-inc#74 of keyword error

* change var name from bool_flag to bool_val
tong-hao pushed a commit to tong-hao/nebula that referenced this issue Jun 1, 2021
* fixed issue vesoft-inc#74 of keyword error

* change var name from bool_flag to bool_val
yixinglu pushed a commit to yixinglu/nebula that referenced this issue Mar 21, 2022
Co-authored-by: bright-starry-sky <56461666+bright-starry-sky@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Type: make the code neat or more efficient
Projects
None yet
Development

No branches or pull requests

3 participants