Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UNION return wrong num of cols #774

Closed
laura-ding opened this issue Aug 15, 2019 · 2 comments · Fixed by #786
Closed

UNION return wrong num of cols #774

laura-ding opened this issue Aug 15, 2019 · 2 comments · Fixed by #786
Assignees
@CPWstatic
Labels
priority/med-pri Priority: medium

Comments

@laura-ding
Copy link
Contributor

laura-ding commented Aug 15, 2019 •
edited

Screen Shot 2019-08-15 at 13 02 45

Screen Shot 2019-08-15 at 12 52 05

Left has two cols, Right has three cols
when the left return null, do right only, so the cols is wrong
@CPWstatic CPWstatic self-assigned this Aug 15, 2019
@CPWstatic
Copy link
Contributor

Thank you!

@whitewum
Copy link
Contributor

Good catch

@CPWstatic CPWstatic mentioned this issue Aug 15, 2019
Closed
@whitewum whitewum added the priority/med-pri Priority: medium label Aug 15, 2019
@CPWstatic CPWstatic mentioned this issue Aug 15, 2019
Merged
liwenhui-soul pushed a commit to liwenhui-soul/nebula that referenced this issue May 10, 2022
@nebula-bots @pengweisong
add code for part peers backward compatible (vesoft-inc#774)
f80268e 
<!--
Thanks for your contribution!
In order to review PR more efficiently, please add information according to the template.
-->

## What type of PR is this?
- [x] bug
- [ ] feature
- [ ] enhancement

## What problem(s) does this PR solve?
#### Issue(s) number: 

#### Description:
When persist peers info in the storage, we should remember to fill the data which upgrade from the old version.

## How do you solve it?

Move the balance peer info to another system table: balance table.
When start the storaged, we should:
1. load the balance parts.
2. load the local parts. 
    - If the part already exist in the balance parts, skip it.
    - Else if the part the part not in the part manager, skip it.
3. load the parts from part manager.
    - If the part already been created, skip it.
    - Will not erase any part in this phase.

## Special notes for your reviewer, ex. impact of this fix, design document, etc:



## Checklist:
Tests:
- [ ] Unit test(positive and negative cases)
- [ ] Function test
- [ ] Performance test
- [ ] N/A

Affects:
- [ ] Documentation affected (Please add the label if documentation needs to be modified.)
- [ ] Incompatibility (If it breaks the compatibility, please describe it and add the label.）
- [ ] If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
- [ ] Performance impacted: Consumes more CPU/Memory


## Release notes:

Please confirm whether to be reflected in release notes and how to describe:
> ex. Fixed the bug .....


Migrated from vesoft-inc#4101

Co-authored-by: pengwei.song <90180021+pengweisong@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CPWstatic CPWstatic

Labels
priority/med-pri Priority: medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix giving wrong column names when union has only right result. CPWstatic/nebula
4 participants
@CPWstatic @laura-ding @whitewum @jude-zhu