Support encode for native client #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unit testing passed. |
There was a problem hiding this comment.
Well done! 👍
Thanks for implementing this. Regarding the C++ libraries, our preference is folly, boost, and stl, in that order.
So in this case, I would suggest to use folly::dynamic, unless there is a strong reason that we have to use boost or stl, such as better performance
| namespace nebula { | ||
| namespace dataman { | ||
|
|
||
| typedef boost::any Value; |
There was a problem hiding this comment.
I would suggest to use folly::dynamic
There was a problem hiding this comment.
Thanks for review . Actually I have studied folly::dynamic but I found it don't have float data type and can't pick out between double and float. So I try to use boost::any.
sherman-the-tank
approved these changes
Feb 6, 2019
|
Unit testing passed. |
tong-hao
pushed a commit
to tong-hao/nebula
that referenced
this pull request
Jun 1, 2021
yixinglu
pushed a commit
to yixinglu/nebula
that referenced
this pull request
Mar 21, 2022
Co-authored-by: Shylock Hg <33566796+Shylock-Hg@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support encode for native client