Support Index Operations #1459
Support Index Operations #1459
Conversation
darionyaphet
requested review from
dutor,
CPWstatic,
critical27,
dangleptr,
laura-ding,
whitewum,
jude-zhu,
liuyu85cn and
bright-starry-sky
|
Jenkins go |
|
Unit testing failed. |
src/graph/ShowExecutor.cpp
Outdated
| auto items = std::move(resp).value(); | ||
| resp_ = std::make_unique<cpp2::ExecutionResponse>(); | ||
| std::vector<cpp2::RowValue> rows; | ||
| std::vector<std::string> header{"Index ID", "Name"}; |
There was a problem hiding this comment.
The Index ID should not be known to the user, modify to TagName, WDYT?
There was a problem hiding this comment.
actually it's the index's name :)
|
Unit testing passed. |
|
Please resolve the conflicts, thanks. |
| } | ||
|
|
||
| auto *mc = ectx()->getMetaClient(); | ||
| auto *name = sentence_->indexName(); |
There was a problem hiding this comment.
const is better?
There was a problem hiding this comment.
I don't know what's the practical use ?
There was a problem hiding this comment.
I don't know what's the practical use ?
Actually it's just my code like, here's what I think ：
Reason 1 : The methodsentence_->indexName()return value is a const string *.
Reason 2 : This value is an immutable constant.
There was a problem hiding this comment.
I think the index name is immutable. The compiler maybe have some optimization for the const auto* .
| auto cb = [this] (auto &&resp) { | ||
| if (!resp.ok()) { | ||
| DCHECK(onError_); | ||
| onError_(std::move(resp).status()); |
There was a problem hiding this comment.
std::move takes an object and allows you to treat it as a temporary.
std::forward has a single use case: to cast a templated function parameter to the value category the caller used to pass it.
When the parameter is an rvalue, they are treated are the same.
|
Unit testing passed. |
1 similar comment
|
Unit testing passed. |
|
Unit testing passed. |
Conflicts: src/graph/SchemaHelper.cpp src/parser/parser.yy
|
Unit testing passed. |
1 similar comment
|
Unit testing passed. |
| properties.emplace(std::move(edgeName), std::move(fields)); | ||
| return createEdgeIndex(spaceID, | ||
| std::move(indexName), | ||
| std::move(properties), |
There was a problem hiding this comment.
Do we support create index on multi fields? It seems storage only support index on first field?
There was a problem hiding this comment.
actually I have update to single schema in another PR
| } | ||
|
|
||
|
|
||
| void DescribeEdgeIndexExecutor::execute() { |
There was a problem hiding this comment.
Do we need desc for index, show index is enough?
There was a problem hiding this comment.
SHOW TAG/EDGE INDEXES will display an index list.
|
Unit testing passed. |
| return edgeName_.get(); | ||
| } | ||
|
|
||
| std::vector<std::string> names() const { |
There was a problem hiding this comment.
naming columns is better?
|
Unit testing failed. |
|
Unit testing passed. |
|
Reference document : #1578 |
|
Unit testing passed. |
|
Unit testing passed. |
|
close #470 |
|
relate to #463 |
No description provided.