Lookup sentence #1705
Lookup sentence #1705
Conversation
bright-starry-sky
requested review from
dangleptr,
darionyaphet,
critical27,
dutor,
laura-ding,
liuyu85cn,
panda-sheep and
sherman-the-tank
|
Ready to review. Thanks. |
| Status LookupExecutor::prepareFrom() { | ||
| from_ = sentence_->from(); | ||
| auto *mc = ectx()->getMetaClient(); | ||
| auto tagResult = mc->getTagIDByNameFromCache(spaceId_, *from_); |
There was a problem hiding this comment.
Do we have forbidden same name in tag and edge?
There was a problem hiding this comment.
Do we have forbidden same name in tag and edge?
Yes, the tag name and edge names are unique. so it's ok.
|
Addressed dangleptr's comments |
|
Add expression check to avoid memory leak |
| traversalExpression(left); | ||
| traversalExpression(right); | ||
| break; | ||
| optimizedPolicy_ = false; |
There was a problem hiding this comment.
Index (col1, col2)
For the expression "co1 > 1 and col1 < 10 and col2 > 5", the index can't be used?
There was a problem hiding this comment.
This index can be used. This is a standard logical expression.
for example in my test :
CREATE EDGE lookup_edge_1(col1 int, col2 int, col3 int);
CREATE EDGE INDEX e_index_1 ON lookup_edge_1(col1, col2, col3);
LOOKUP ON lookup_edge_1 WHERE lookup_edge_1.col1 >1 and lookup_edge_1.col1 < 3 and lookup_edge_1.col2 > 1;
Execution succeeded (Time spent: 2.461/4.992 ms)
src/graph/test/LookupTest.cpp
Outdated
| {200}, | ||
| }; | ||
| ASSERT_TRUE(verifyResult(resp, expected)); | ||
| ASSERT_TRUE(verifyResult(resp, expected)); |
| status = checkIfGraphSpaceChosen(); | ||
| if (!status.ok()) { | ||
| break; | ||
| } |
There was a problem hiding this comment.
a suggestion, line 24 and line 27 move here
There was a problem hiding this comment.
good suggestion.
src/graph/LookupExecutor.cpp
Outdated
| } else { | ||
| result.emplace_back("VertexID"); | ||
| } | ||
| result.reserve(yields_.size()); |
There was a problem hiding this comment.
Sharp eyes
…xPrefix from index key. 3: Removed IndexItem from all thrift requests. 3: Moved hint from storage.thrift to common.thrift
…, 3, Remove IndexOptimizer class, 4, Add testcases
bright-starry-sky
dismissed stale reviews from panda-sheep and dangleptr
via
c2519a8
|
Addressed panda-sheep's comment. |
|
close #465 |
This PR based on PR #1437.