Add config for AWS EC2 c5d.xlarge #1833
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
refer to #1831 |
dangleptr
reviewed
Jul 14, 2020
| @@ -1,3 +1,9 @@ | |||
| ########## bench ########### | |||
There was a problem hiding this comment.
Why rename conf.production to conf.c5d.xlarge
|
|
|
Maybe we should have another config file to adapt EC2？ |
Agree. I'll close this one. |
yixinglu
pushed a commit
to yixinglu/nebula
that referenced
this pull request
Jan 31, 2023
* Fix rewrite edge node filter. * Fix return null. Co-authored-by: jie.wang <38901892+jievince@users.noreply.github.com> Co-authored-by: shylock <33566796+Shylock-Hg@users.noreply.github.com> Co-authored-by: jie.wang <38901892+jievince@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
I think an AWS EC2 config will be more comparable/illustrative for users to set conf file.
Why are the changes needed?
These are conf file examples. I've been asked many times of recommended configs.
AWS EC2 is typical. AWS EC2 xlarge is for minimal & 12xlarge is for standard usage.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Not necessary.