go sentence support integer/timestamp type to start traverse. #2225
Conversation
| @@ -191,11 +191,13 @@ InterimResult::buildIndex(const std::string &vidColumn) const { | |||
| auto name = schema->getFieldName(i); | |||
| if (vidColumn == name) { | |||
| VLOG(1) << "col name: " << vidColumn << ", col index: " << i; | |||
| if (schema->getFieldType(i).type != SupportedType::VID) { | |||
| if (schema->getFieldType(i).type != SupportedType::INT && | |||
There was a problem hiding this comment.
I want to know in which situation you need to traverse from "Timestamp" data.....
There was a problem hiding this comment.
For example: find out active users in the last hour/minute.
There was a problem hiding this comment.
For example: find out active users in the last hour/minute.
Sorry, i did not understand it. The time point is one vertex in your case?
There was a problem hiding this comment.
yes, connect action with a timestamp(start of the minute/hour). We can find out the active actions, without index.
There was a problem hiding this comment.
To my knowledge, timestamp has no difference with an integer type. I use timestamp type to be displayed more human-readable
There was a problem hiding this comment.
Interesting.
The pr has no problems in logic. But we need to discuss it futher.
There was a problem hiding this comment.
We both think the improvement is reasonable. Let's go on.
Thanks for your contribution.
|
Please check the failed UTs |
xuguruogu
force-pushed
the
go-input-non-vid
branch
from
9f3445f
to
53f3011
Compare
Amber1990Zhang
added
the
doc affected
|
doc done |
…-inc#2225) Co-authored-by: trippli <trippli@tencent.com> Co-authored-by: dangleptr <37216992+dangleptr@users.noreply.github.com>
support go from integer or timestamp. Just like sentence below: