add a callback register interface of Part #2485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/kvstore/Part.h
Outdated
| }; | ||
|
|
||
| using OnElectedCallBack = std::function<void(const CallbackOptions& opt)>; | ||
| void registerOnElected(OnElectedCallBack cb); |
There was a problem hiding this comment.
Where do we need to call this method?
bright-starry-sky
previously approved these changes
Aug 11, 2021
|
Plz resolve the conflicts~ |
liuyu85cn
dismissed stale reviews from critical27 and bright-starry-sky
via
5dbc3e9
liuyu85cn
force-pushed
the
register_callback_interface_to_raft_part
branch
from
5dbc3e9
to
2e7686a
Compare
liuyu85cn
force-pushed
the
register_callback_interface_to_raft_part
branch
from
2e7686a
to
f18d4fe
Compare
critical27
approved these changes
Aug 19, 2021
critical27
requested review from
critical27,
bright-starry-sky,
cangfengzhs,
darionyaphet and
panda-sheep
bright-starry-sky
approved these changes
Aug 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.