Small improvement to daemons compilation. #2488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yixinglu
previously approved these changes
Aug 11, 2021
CPWstatic
previously approved these changes
Aug 11, 2021
yixinglu
reviewed
Aug 11, 2021
bright-starry-sky
dismissed stale reviews from CPWstatic and yixinglu
via
8910d92
yixinglu
previously approved these changes
Aug 11, 2021
|
Please hold this PR. I need this PR to debug the stability of the CI. |
yixinglu
reviewed
Aug 11, 2021
|
Ready to merge. Thanks. |
yixinglu
previously approved these changes
Aug 12, 2021
|
Could you solve the conflicts about the target changes: |
bright-starry-sky
force-pushed
the
cmake_file_correct
branch
from
2e58755
to
990dff0
Compare
Sure, rebased. |
yixinglu
approved these changes
Aug 16, 2021
CPWstatic
approved these changes
Aug 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One small improvement is the classification of public libraries.
Test linters and CI by the way.