Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename inline headers #2504

Merged
merged 4 commits into from
Aug 12, 2021
Merged

Rename inline headers #2504

merged 4 commits into from
Aug 12, 2021

Conversation

yixinglu
Copy link
Contributor

  1. follow google code style source file name format
  2. Some editors do not recognize files with the inl suffix as c++ source files by default
  3. The new suffix brings extra work to many scripts

@yixinglu yixinglu added the ready-for-testing PR: ready for the CI test label Aug 11, 2021
@yixinglu yixinglu requested a review from a team August 11, 2021 16:09
@yixinglu yixinglu merged commit b93fee4 into vesoft-inc:master Aug 12, 2021
@yixinglu yixinglu deleted the rename-inline-headers branch August 12, 2021 03:11
@jamieliu1023 jamieliu1023 mentioned this pull request Aug 14, 2021
Closed
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Sep 14, 2023
@Aiee
[License Manager Adaption] Report graph/storage cpu cores to meta (ve…
9c57b75 
…soft-inc#2504)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CPWstatic CPWstatic CPWstatic approved these changes

@bright-starry-sky bright-starry-sky bright-starry-sky approved these changes

Assignees
No one assigned
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yixinglu @CPWstatic @bright-starry-sky