Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename some non-standard types #2547

Merged
merged 4 commits into from
Aug 23, 2021
Merged

Rename some non-standard types #2547

merged 4 commits into from
Aug 23, 2021

Conversation

yixinglu
Copy link
Contributor

  1. RunTimeContext -> RuntimeContext
  2. Statis -> Stats
  3. Builder.finish() -> Builder.build()

@yixinglu yixinglu added the ready-for-testing PR: ready for the CI test label Aug 22, 2021
@yixinglu yixinglu requested a review from a team August 22, 2021 17:26
jievince
jievince approved these changes Aug 23, 2021
View reviewed changes
Copy link
Contributor

@jievince jievince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yixinglu yixinglu merged commit 2e7d75b into vesoft-inc:master Aug 23, 2021
@yixinglu yixinglu deleted the rename branch August 23, 2021 10:06
@jamieliu1023 jamieliu1023 mentioned this pull request Aug 28, 2021
Closed
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Sep 14, 2023
@nevermore3 @Sophie-Xie
fix privilege (vesoft-inc#2547)
96abd01 
* fix privilege

* add comment

---------

Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nevermore3 nevermore3 nevermore3 approved these changes

@jievince jievince jievince approved these changes

Assignees
No one assigned
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yixinglu @nevermore3 @jievince