Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support return query result as a Json string #2824

Merged
merged 12 commits into from
Sep 22, 2021
Merged

Support return query result as a Json string #2824

merged 12 commits into from
Sep 22, 2021

Conversation

Aiee
Copy link
Contributor

@Aiee Aiee commented Sep 8, 2021 •
edited
Loading

As title.

closing #2586

@Aiee Aiee added wip Solution: work in progress ready-for-testing PR: ready for the CI test new feature labels Sep 8, 2021
@Aiee Aiee linked an issue Sep 8, 2021 that may be closed by this pull request
[QE]Query engine returns results in JSON format #2586
Closed
@Aiee Aiee force-pushed the support-Json-query-result branch 2 times, most recently from c86e7ba to a3e82b8 Compare September 13, 2021 09:09
@Aiee Aiee mentioned this pull request Sep 13, 2021
Merged
@Aiee Aiee requested a review from a team September 13, 2021 09:41
@Aiee Aiee removed the wip Solution: work in progress label Sep 13, 2021
@Shylock-Hg
Copy link
Contributor

Need end to end case in TCK.

@Aiee Aiee changed the title Support return query result as a Json strcut Support return query result as a Json string Sep 13, 2021
@Aiee
Copy link
Contributor Author

Aiee commented Sep 14, 2021 •
edited
Loading

Need end to end case in TCK.

I'll add TCK in another PR after python client update

@Aiee Aiee mentioned this pull request Sep 14, 2021
Merged
@Aiee Aiee force-pushed the support-Json-query-result branch 2 times, most recently from aa67549 to 6e76d96 Compare September 15, 2021 08:50
@Sophie-Xie Sophie-Xie requested review from CPWstatic, jievince and yixinglu and removed request for a team and CPWstatic September 16, 2021 05:17
yixinglu
yixinglu reviewed Sep 16, 2021
View reviewed changes
src/common/datatypes/DataSet.h Outdated Show resolved Hide resolved
src/common/datatypes/DataSet.h Outdated Show resolved Hide resolved
src/common/datatypes/Date.h Outdated Show resolved Hide resolved
yixinglu
yixinglu approved these changes Sep 18, 2021
View reviewed changes
Copy link
Contributor

@yixinglu yixinglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jievince
jievince approved these changes Sep 20, 2021
View reviewed changes
Copy link
Contributor

@jievince jievince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yixinglu yixinglu merged commit 32ff73f into vesoft-inc:master Sep 22, 2021
@Aiee Aiee deleted the support-Json-query-result branch September 22, 2021 02:56
@whitewum
Copy link
Contributor

doc required?

@Aiee
Copy link
Contributor Author

Aiee commented Sep 23, 2021 •
edited
Loading

doc required?

Not really here. Users are not able to trigger this functionality via queries.
I'll update the README of clients' repos, and this should be sufficient.

@yixinglu yixinglu added the doc affected PR: improvements or additions to documentation label Sep 24, 2021
This was referenced Oct 20, 2021
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yixinglu yixinglu yixinglu approved these changes

@jievince jievince jievince approved these changes

Assignees
No one assigned
Labels
doc affected PR: improvements or additions to documentation ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[QE]Query engine returns results in JSON format
5 participants
@Aiee @Shylock-Hg @whitewum @yixinglu @jievince