Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix running jobs in dropped space block others #2832

Merged
merged 3 commits into from
Sep 14, 2021
Merged

fix running jobs in dropped space block others #2832

merged 3 commits into from
Sep 14, 2021

Conversation

critical27
Copy link
Contributor

close #2809

@critical27 critical27 added the ready-for-testing PR: ready for the CI test label Sep 9, 2021
yixinglu
yixinglu reviewed Sep 9, 2021
View reviewed changes
Copy link
Contributor

@yixinglu yixinglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add some tests for this bugfix ?

@critical27
Copy link
Contributor Author

Could you add some tests for this bugfix ?

This case can't be stable in pytest, it depends on execution time precisely. I'll ask a colleague to write some cases with gmock in another PR.

@critical27 critical27 merged commit 8060de8 into vesoft-inc:master Sep 14, 2021
@critical27 critical27 deleted the fix branch September 14, 2021 05:59
@jamieliu1023 jamieliu1023 mentioned this pull request Sep 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yixinglu yixinglu yixinglu left review comments

@liuyu85cn liuyu85cn liuyu85cn approved these changes

@panda-sheep panda-sheep panda-sheep approved these changes

@darionyaphet darionyaphet Awaiting requested review from darionyaphet

@cangfengzhs cangfengzhs Awaiting requested review from cangfengzhs

@liwenhui-soul liwenhui-soul Awaiting requested review from liwenhui-soul

@bright-starry-sky bright-starry-sky Awaiting requested review from bright-starry-sky

Assignees
No one assigned
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

negative case for rebuild index
4 participants
@critical27 @yixinglu @liuyu85cn @panda-sheep