Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup static variables in header files #2890

Merged
merged 3 commits into from
Sep 17, 2021
Merged

Cleanup static variables in header files #2890

merged 3 commits into from
Sep 17, 2021

Conversation

yixinglu
Copy link
Contributor

We should not directly define static variables in the header file

@yixinglu yixinglu added the ready-for-testing PR: ready for the CI test label Sep 17, 2021
@yixinglu yixinglu merged commit 77173a9 into vesoft-inc:master Sep 17, 2021
@yixinglu yixinglu deleted the web-common branch September 17, 2021 15:11
@jamieliu1023 jamieliu1023 mentioned this pull request Sep 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aiee Aiee Aiee approved these changes

@Shylock-Hg Shylock-Hg Shylock-Hg approved these changes

Assignees
No one assigned
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yixinglu @Aiee @Shylock-Hg