Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change error code in JSON to Int #2926

Merged
merged 4 commits into from
Sep 27, 2021

Conversation

Aiee
Copy link
Contributor

@Aiee Aiee commented Sep 24, 2021

  1. Change error code in JSON to In
  2. Correct JSON format:
{
  "results": [
    {
      "columns": [],
      "data": [
        {
          "row": [
            "row-data"
          ],
          "meta": [
            "metadata"
          ]
        }
      ],
      "latencyInUs": 0,
      "spaceName": "",
      "planDesc ": {
        "planNodeDescs": [
          {
            "name": "",
            "id": 0,
            "outputVar": "",
            "description": {
              "key": ""
            },
            "profiles": [
              {
                "rows": 1,
                "execDurationInUs": 0,
                "totalDurationInUs": 0,
                "otherStats": {}
              }
            ],
            "branchInfo": {
              "isDoBranch": false,
              "conditionNodeId": -1
            },
            "dependencies": []
          }
        ],
        "nodeIndexMap": {},
        "format": "",
        "optimize_time_in_us": 0
      },
      "comment ": ""
    }
  ],
  "errors": [
    {
      "code": 0,
      "message": ""
    }
  ]
}
  1. Make the JSON in the comment look nicer.

@Aiee Aiee added the ready-for-testing PR: ready for the CI test label Sep 24, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2021

Codecov Report

Merging #2926 (0362474) into master (dddf54e) will decrease coverage by 0.71%.
The diff coverage is 63.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2926      +/-   ##
==========================================
- Coverage   85.47%   84.75%   -0.72%     
==========================================
  Files        1229     1231       +2     
  Lines      110375   110807     +432     
==========================================
- Hits        94341    93915     -426     
- Misses      16034    16892     +858     
Impacted Files Coverage Δ
src/clients/meta/MetaClient.h 92.30% <ø> (ø)
src/common/utils/NebulaKeyUtils.cpp 89.03% <0.00%> (-4.89%) ⬇️
src/common/utils/NebulaKeyUtils.h 78.02% <ø> (ø)
src/graph/planner/plan/Admin.cpp 54.23% <0.00%> (-2.40%) ⬇️
src/graph/planner/plan/PlanNode.h 80.00% <ø> (ø)
src/graph/service/PermissionCheck.cpp 83.72% <ø> (+2.32%) ⬆️
src/kvstore/KVEngine.h 100.00% <ø> (ø)
src/kvstore/RocksEngine.cpp 81.79% <0.00%> (-1.73%) ⬇️
src/kvstore/RocksEngine.h 66.66% <0.00%> (-25.00%) ⬇️
src/meta/MetaServiceHandler.h 100.00% <ø> (ø)
... and 121 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 073fb37...0362474. Read the comment docs.

jievince
jievince previously approved these changes Sep 26, 2021
yixinglu
yixinglu previously approved these changes Sep 26, 2021
@Aiee Aiee dismissed stale reviews from yixinglu and jievince via 0362474 September 27, 2021 06:44
@Aiee Aiee changed the title [Minor] Reformat JSON in the comment [Minor] Change error code in JSON to Int Sep 27, 2021
yixinglu
yixinglu previously approved these changes Sep 27, 2021
Copy link
Contributor

@yixinglu yixinglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

HarrisChu
HarrisChu previously approved these changes Sep 27, 2021
Nicole00
Nicole00 previously approved these changes Sep 27, 2021
@yixinglu yixinglu self-requested a review September 27, 2021 11:12
@Aiee Aiee changed the title [Minor] Change error code in JSON to Int Change error code in JSON to Int Sep 27, 2021
@Sophie-Xie Sophie-Xie added this to the v2.6.0 milestone Sep 27, 2021
@bright-starry-sky bright-starry-sky merged commit fc88814 into vesoft-inc:master Sep 27, 2021
@Aiee Aiee deleted the fix-json-format branch September 27, 2021 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants