Add client version verification test. #3032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CPWstatic
added
ready-for-testing
CPWstatic
force-pushed
the
add_verify_client_test
branch
2 times, most recently
from
0b30f92
to
9ce8711
Compare
Shylock-Hg
approved these changes
Oct 12, 2021
Aiee
reviewed
Oct 12, 2021
| graph_spaces["resp"] = conn.verifyClientVersion(req) | ||
| conn._iprot.trans.close() | ||
|
|
||
| @then(parse("the connection should be rejected")) |
There was a problem hiding this comment.
Should specify the message since other errors would also cause the connection to be rejected? We could parse something like Connection rejected because of client version mismtach
Comment on lines
+562
to
+565
| @then(parse("the connection should be rejected")) | ||
| def check_client_compatible(graph_spaces): | ||
| resp = graph_spaces["resp"] | ||
| assert resp.error_code == ErrorCode.E_CLIENT_SERVER_INCOMPATIBLE, f'The client was not rejected by server: {resp}' |
There was a problem hiding this comment.
The client might be rejected for other errors. f'Expected error: ErrorCode.E_CLIENT_SERVER_INCOMPATIBLE, got : {resp.error_code}'
yixinglu
approved these changes
Oct 12, 2021
Codecov Report
@@ Coverage Diff @@
## master #3032 +/- ##
==========================================
- Coverage 84.20% 84.19% -0.01%
==========================================
Files 1287 1287
Lines 115319 115319
==========================================
- Hits 97100 97098 -2
- Misses 18219 18221 +2
Continue to review full report at Codecov.
|
Sophie-Xie
pushed a commit
that referenced
this pull request
Oct 13, 2021
Co-authored-by: Yee <2520865+yixinglu@users.noreply.github.com>
critical27
pushed a commit
that referenced
this pull request
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After vesoft-inc/nebula-python#148