Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize rewrite visitor #3053

Merged
merged 20 commits into from
Nov 24, 2021
Merged

Conversation

czpmango
Copy link
Contributor

Rewrite expressions in-place.

@czpmango czpmango added the ready-for-testing PR: ready for the CI test label Oct 13, 2021
@Sophie-Xie Sophie-Xie modified the milestones: v2.7.0, v3.0.0 Oct 14, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2021

Codecov Report

Merging #3053 (35248c2) into master (4dd4a26) will decrease coverage by 0.04%.
The diff coverage is 84.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3053      +/-   ##
==========================================
- Coverage   85.29%   85.24%   -0.05%     
==========================================
  Files        1289     1289              
  Lines      119969   119978       +9     
==========================================
- Hits       102329   102279      -50     
- Misses      17640    17699      +59     
Impacted Files Coverage Δ
src/graph/visitor/RewriteVisitor.cpp 76.37% <50.00%> (ø)
src/graph/planner/match/MatchClausePlanner.cpp 98.82% <100.00%> (+0.01%) ⬆️
src/graph/validator/GroupByValidator.cpp 95.28% <100.00%> (ø)
src/graph/validator/MatchValidator.cpp 86.44% <100.00%> (-0.08%) ⬇️
src/meta/processors/parts/GetSpaceProcessor.cpp 60.60% <0.00%> (-18.19%) ⬇️
src/meta/processors/BaseProcessor.h 75.67% <0.00%> (-16.22%) ⬇️
src/graph/context/Result.cpp 85.00% <0.00%> (-9.45%) ⬇️
src/storage/exec/IndexNode.cpp 91.66% <0.00%> (-8.34%) ⬇️
src/graph/executor/StorageAccessExecutor.h 71.79% <0.00%> (-6.42%) ⬇️
src/common/thrift/ThriftClientManager-inl.h 82.97% <0.00%> (-6.39%) ⬇️
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f449c17...35248c2. Read the comment docs.

@yixinglu yixinglu merged commit b7c6901 into vesoft-inc:master Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants