fix bug#3048 #3069
Merged
fix bug#3048 #3069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhaohaifei
added
ready-for-testing
yixinglu
approved these changes
Oct 14, 2021
jievince
reviewed
Oct 14, 2021
| @@ -41,13 +41,16 @@ Status GraphService::init(std::shared_ptr<folly::IOThreadPoolExecutor> ioExecuto | |||
| bool loadDataOk = metaClient_->waitForMetadReady(3); | |||
| if (!loadDataOk) { | |||
| // Resort to retrying in the background | |||
| LOG(WARNING) << "Failed to wait for meta service ready synchronously."; | |||
| LOG(ERROR) << "Failed to wait for meta service ready synchronously."; | |||
| return Status::Error("Failed to wait for meta service ready synchronously."); | |||
There was a problem hiding this comment.
Why log and return the same error msg?
There was a problem hiding this comment.
The second log is for upper calling.
nevermore3
approved these changes
Oct 14, 2021
Shylock-Hg
approved these changes
Oct 14, 2021
Sophie-Xie
pushed a commit
that referenced
this pull request
Oct 15, 2021
yixinglu
added a commit
that referenced
this pull request
Oct 18, 2021
* Expression test modify (#3041) * modify expression test * modify expression test 2 * complete coding * fix bug * modify expression test case * clang-format * fix bug:initialization-order-fiasco * add some obj * add test_path_function Co-authored-by: cpw <13495049+CPWstatic@users.noreply.github.com> * add hash<set> & hash<map> (#3051) * fix dangling edge in path (#3008) * fix dangling edge * add test case * fix ci error * Fix graph/meta/storage version in show hosts (#3054) * Fix graph version bug * Fix storage version * Print cpack config * Decrease ubuntu compile parallelism * fix bug #3048 (#3069) Co-authored-by: haifei.zhao <32253291+zhaohaifei@users.noreply.github.com> Co-authored-by: cpw <13495049+CPWstatic@users.noreply.github.com> Co-authored-by: jimingquan <mingquan.ji@vesoft.com> Co-authored-by: Yee <2520865+yixinglu@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #3048