Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix PushLimitDownProjRule #3167

Merged
merged 2 commits into from
Oct 21, 2021
Merged

fix PushLimitDownProjRule #3167

merged 2 commits into from
Oct 21, 2021

Conversation

czpmango
Copy link
Contributor

@czpmango czpmango commented Oct 20, 2021 •
edited

Fixes #3121

@czpmango czpmango added ready-for-testing PR: ready for the CI test do not review PR: not ready for the code review yet and removed ready-for-testing PR: ready for the CI test labels Oct 20, 2021
@czpmango czpmango added the ready-for-testing PR: ready for the CI test label Oct 20, 2021
Shylock-Hg
Shylock-Hg previously approved these changes Oct 20, 2021
View reviewed changes
Copy link
Contributor

@Shylock-Hg Shylock-Hg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jievince
jievince previously approved these changes Oct 20, 2021
View reviewed changes
Copy link
Contributor

@jievince jievince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sophie-Xie Sophie-Xie added cherry-pick-v2.6 PR: need cherry-pick to this version and removed do not review PR: not ready for the code review yet labels Oct 20, 2021
@czpmango czpmango added cherry-pick-v2.6 PR: need cherry-pick to this version and removed cherry-pick-v2.6 PR: need cherry-pick to this version labels Oct 20, 2021
bright-starry-sky
bright-starry-sky suggested changes Oct 20, 2021
View reviewed changes
Copy link
Contributor

@bright-starry-sky bright-starry-sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code with implicit null pointer references

@czpmango czpmango dismissed stale reviews from jievince and Shylock-Hg via 3e43fdf October 20, 2021 09:44
yixinglu
yixinglu previously approved these changes Oct 20, 2021
View reviewed changes
@Sophie-Xie Sophie-Xie removed their request for review October 21, 2021 02:46
@yixinglu yixinglu merged commit 2a0f901 into vesoft-inc:master Oct 21, 2021
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Oct 21, 2021
@czpmango @yixinglu
fix PushLimitDownProjRule (vesoft-inc#3167)
9372528
critical27 pushed a commit that referenced this pull request Oct 22, 2021
@yixinglu @czpmango @Shylock-Hg
Cherry pick V2.6.0 1021 (#3177)
1a82164 
* Fix the interval time of memory checking in graph background thread (#3175)

* Move ScopedTimer from graph to common module

* fix PushLimitDownProjRule (#3167)

* Fix the lookup limit result (#3171)

* Fix the lookup limit result.

* Stablize the limit cast in multiple storage nodes.

* Remove limit clause of lookup.

Co-authored-by: kyle.cao <kyle.cao@vesoft.com>
Co-authored-by: Shylock Hg <33566796+Shylock-Hg@users.noreply.github.com>
@jamieliu1023 jamieliu1023 mentioned this pull request Nov 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yixinglu yixinglu yixinglu approved these changes

@jievince jievince jievince approved these changes

@Shylock-Hg Shylock-Hg Shylock-Hg left review comments

@bright-starry-sky bright-starry-sky bright-starry-sky left review comments

Assignees
No one assigned
Labels
cherry-pick-v2.6 PR: need cherry-pick to this version ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The Match statement cannot return the correct result if limit is added
6 participants
@czpmango @yixinglu @Shylock-Hg @jievince @bright-starry-sky @Sophie-Xie