Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DSS part7: Separate Metakey Utils from meta service utils #3176

Merged
merged 2 commits into from
Oct 21, 2021
Merged

DSS part7: Separate Metakey Utils from meta service utils #3176

merged 2 commits into from
Oct 21, 2021

Conversation

panda-sheep
Copy link
Contributor

The meta key utils are also used in other modules.
Use it as the common part.

@panda-sheep panda-sheep changed the title Separate Metakey Utils from meta service utils DSS part7 Separate Metakey Utils from meta service utils Oct 21, 2021
@panda-sheep panda-sheep changed the title DSS part7 Separate Metakey Utils from meta service utils DSS part7: Separate Metakey Utils from meta service utils Oct 21, 2021
@panda-sheep panda-sheep added the ready-for-testing PR: ready for the CI test label Oct 21, 2021
critical27
critical27 approved these changes Oct 21, 2021
View reviewed changes
Copy link
Contributor

@critical27 critical27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with this, for listener/drainer later.

bright-starry-sky
bright-starry-sky approved these changes Oct 21, 2021
View reviewed changes
Copy link
Contributor

@bright-starry-sky bright-starry-sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

liuyu85cn
liuyu85cn approved these changes Oct 21, 2021
View reviewed changes
Copy link
Contributor

@liuyu85cn liuyu85cn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bright-starry-sky bright-starry-sky merged commit 349b685 into vesoft-inc:master Oct 21, 2021
@panda-sheep panda-sheep deleted the spm branch October 21, 2021 10:35
@jamieliu1023 jamieliu1023 mentioned this pull request Nov 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@critical27 critical27 critical27 approved these changes

@liuyu85cn liuyu85cn liuyu85cn approved these changes

@bright-starry-sky bright-starry-sky bright-starry-sky approved these changes

@darionyaphet darionyaphet Awaiting requested review from darionyaphet

Assignees
No one assigned
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@panda-sheep @critical27 @liuyu85cn @bright-starry-sky @nebula-bots