Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix geo predicate rule and geography isvalid #3180

Merged
merged 4 commits into from
Oct 22, 2021
Merged

fix geo predicate rule and geography isvalid #3180

merged 4 commits into from
Oct 22, 2021

Conversation

jievince
Copy link
Contributor

No description provided.

@jievince jievince added ready-for-testing PR: ready for the CI test type/bug Type: something is unexpected cherry-pick-v2.6 PR: need cherry-pick to this version labels Oct 21, 2021
yixinglu
yixinglu previously approved these changes Oct 21, 2021
View reviewed changes
@codecov-commenter
Copy link

Codecov Report

Merging #3180 (ba66f80) into master (50b1760) will increase coverage by 0.07%.
The diff coverage is 86.70%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3180      +/-   ##
==========================================
+ Coverage   85.17%   85.25%   +0.07%     
==========================================
  Files        1294     1295       +1     
  Lines      118261   118262       +1     
==========================================
+ Hits       100733   100819      +86     
+ Misses      17528    17443      -85
Impacted Files Coverage Δ
src/common/time/ScopedTimer.h 100.00% <ø> (ø)
src/common/time/test/ScopedTimerTest.cpp 100.00% <ø> (ø)
src/common/utils/IndexKeyUtils.h 90.25% <ø> (+0.56%) ⬆️
src/graph/executor/Executor.cpp 84.02% <ø> (ø)
src/graph/executor/Executor.h 100.00% <ø> (ø)
src/graph/executor/admin/CharsetExecutor.cpp 100.00% <ø> (ø)
src/graph/executor/admin/ConfigExecutor.cpp 94.54% <ø> (ø)
src/graph/executor/admin/GroupExecutor.cpp 67.90% <ø> (ø)
src/graph/executor/admin/PartExecutor.cpp 96.55% <ø> (ø)
src/graph/executor/admin/ShowHostsExecutor.cpp 93.47% <ø> (ø)
... and 188 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 349b685...ba66f80. Read the comment docs.

@yixinglu yixinglu merged commit db6da98 into vesoft-inc:master Oct 22, 2021
Sophie-Xie pushed a commit that referenced this pull request Oct 22, 2021
@jievince @Sophie-Xie
fix geo predicate rule and geography isvalid (#3180)
646aa1b
jievince added a commit to jievince/nebula that referenced this pull request Oct 22, 2021
@jievince
fix geo predicate rule and geography isvalid (vesoft-inc#3180)
ca3fca9
CPWstatic added a commit that referenced this pull request Oct 22, 2021
@Sophie-Xie @jievince @CPWstatic
fix geo predicate rule and geography isvalid (#3180) (#3182)
2080890 
Co-authored-by: jie.wang <38901892+jievince@users.noreply.github.com>
Co-authored-by: cpw <13495049+CPWstatic@users.noreply.github.com>
@jievince jievince deleted the geo-fix branch October 25, 2021 04:46
@jamieliu1023 jamieliu1023 mentioned this pull request Nov 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yixinglu yixinglu yixinglu approved these changes

@CPWstatic CPWstatic CPWstatic approved these changes

@FangJinhe FangJinhe FangJinhe approved these changes

@Aiee Aiee Awaiting requested review from Aiee

Assignees
No one assigned
Labels
cherry-pick-v2.6 PR: need cherry-pick to this version ready-for-testing PR: ready for the CI test type/bug Type: something is unexpected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jievince @codecov-commenter @yixinglu @CPWstatic @FangJinhe