fix crash when drop space #3185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
critical27
added
ready-for-testing
critical27
requested review from
yixinglu,
CPWstatic,
liuyu85cn,
bright-starry-sky,
Sophie-Xie and
SuperYoko
Codecov Report
@@ Coverage Diff @@
## master #3185 +/- ##
==========================================
+ Coverage 85.17% 85.22% +0.04%
==========================================
Files 1294 1295 +1
Lines 118261 118264 +3
==========================================
+ Hits 100733 100793 +60
+ Misses 17528 17471 -57
Continue to review full report at Codecov.
|
CPWstatic
approved these changes
Oct 22, 2021
| @@ -124,8 +124,8 @@ RocksEngine::RocksEngine(GraphSpaceID spaceId, | |||
| } | |||
| CHECK(status.ok()) << status.ToString(); | |||
| db_.reset(db); | |||
| partsNum_ = allParts().size(); | |||
| extractorLen_ = sizeof(PartitionID) + vIdLen; | |||
There was a problem hiding this comment.
why can this modification avoid crash?
There was a problem hiding this comment.
allParts need to be correct, if it is initialized before we set extractorLen_, allParts will be wrong
yixinglu
approved these changes
Oct 22, 2021
Sophie-Xie
pushed a commit
that referenced
this pull request
Oct 22, 2021
critical27
added a commit
that referenced
this pull request
Oct 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reproduce procedure:
show hosts