Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement #3223

Merged
merged 5 commits into from
Oct 29, 2021
Merged

Enhancement #3223

merged 5 commits into from
Oct 29, 2021

Conversation

jackwener
Copy link
Contributor

@jackwener jackwener commented Oct 27, 2021

What type of PR is this?

  • enhancement

Which issue(s) this PR fixes:

None

What this PR does / why we need it?

We need add issue template for developer

Checklist:

  • Documentation affected (If need to modify document, please label it.)

Release notes:

None `

@jackwener jackwener added the doc affected PR: improvements or additions to documentation label Oct 27, 2021
@Sophie-Xie Sophie-Xie removed the doc affected PR: improvements or additions to documentation label Oct 28, 2021
Copy link
Contributor

@Sophie-Xie Sophie-Xie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls add the template, and I am not sure whether need to change the order of title and lables

@jackwener
Copy link
Contributor Author

jackwener commented Oct 28, 2021

@Sophie-Xie PTAL.

Besides, what should I add? Maybe I haven’t considered some content

@jackwener jackwener added the ready-for-testing PR: ready for the CI test label Oct 29, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #3223 (5feb163) into master (1de911d) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3223      +/-   ##
==========================================
- Coverage   85.26%   85.25%   -0.02%     
==========================================
  Files        1295     1295              
  Lines      118185   118192       +7     
==========================================
- Hits       100775   100759      -16     
- Misses      17410    17433      +23     
Impacted Files Coverage Δ
src/kvstore/raftex/Host.cpp 63.68% <0.00%> (-8.94%) ⬇️
...eta/processors/session/SessionManagerProcessor.cpp 74.19% <0.00%> (-4.52%) ⬇️
src/common/thread/GenericWorker.h 92.30% <0.00%> (-3.85%) ⬇️
src/meta/processors/parts/ListHostsProcessor.cpp 72.13% <0.00%> (-2.00%) ⬇️
src/graph/session/GraphSessionManager.cpp 79.88% <0.00%> (-1.73%) ⬇️
src/common/utils/IndexKeyUtils.h 89.68% <0.00%> (-0.91%) ⬇️
src/kvstore/Part.cpp 54.13% <0.00%> (-0.57%) ⬇️
src/meta/processors/BaseProcessor-inl.h 87.21% <0.00%> (-0.57%) ⬇️
src/common/network/NetworkUtils.cpp 80.89% <0.00%> (-0.57%) ⬇️
src/graph/util/SchemaUtil.cpp 92.82% <0.00%> (-0.40%) ⬇️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1de911d...5feb163. Read the comment docs.

@yixinglu yixinglu merged commit a101981 into vesoft-inc:master Oct 29, 2021
yixinglu pushed a commit that referenced this pull request Nov 3, 2021
yixinglu added a commit that referenced this pull request Nov 3, 2021
* Enhancement (#3223)

* Remove Common Clause License (#3263)

* Remove Common Clause 1.0 License

* Again

* Cleanup CC

* Cleanup useless files

Co-authored-by: jakevin <30525741+jackwener@users.noreply.github.com>
@jackwener jackwener deleted the enhancement branch January 18, 2022 07:19
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Mar 21, 2022
Co-authored-by: jakevin <30525741+jackwener@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants