Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Minor] Fix typos in the template #3234

Merged
merged 4 commits into from
Nov 3, 2021
Merged

Conversation

Aiee
Copy link
Contributor

@Aiee Aiee commented Oct 29, 2021

What type of PR is this?

  • bug
  • feature

Which issue(s) this PR fixes:

close #xxx
(If it is requirement, issue(s) number must be listed.)

What this PR does / why we need it?

Fix typos/grammar in the template

Special notes for your reviewer, ex. impact of this fix, etc:

Additional context:

Checklist:

  • Documentation affected (If need to modify document, please label it.)
  • Incompatible (If it is incompatile, please describle it and label it.)
  • Need to cherry pick (If need to cherry pick to some branchs, please label the destination version(s).)
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory

Release notes:

Please confirm whether to reflect in release notes and how to describe:

                                                            `

@@ -6,7 +6,7 @@
close #xxx
(If it is requirement, issue(s) number must be listed.)

#### What this PR does / why we need it?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this PR do? Why we need it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't delete Why we need it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's redundant.

@Aiee Aiee added the ready-for-testing PR: ready for the CI test label Oct 29, 2021
Copy link
Contributor

@Sophie-Xie Sophie-Xie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cherry-pick --> cherry pick

@Aiee
Copy link
Contributor Author

Aiee commented Oct 29, 2021

cherry-pick --> cherry pick

https://dictionary.cambridge.org/dictionary/english/cherry-pick

@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2021

Codecov Report

Merging #3234 (985fc24) into master (a101981) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3234      +/-   ##
==========================================
- Coverage   85.26%   85.22%   -0.04%     
==========================================
  Files        1295     1295              
  Lines      118177   118188      +11     
==========================================
- Hits       100758   100728      -30     
- Misses      17419    17460      +41     
Impacted Files Coverage Δ
src/graph/executor/StorageAccessExecutor.h 64.10% <0.00%> (-7.70%) ⬇️
src/common/thrift/ThriftClientManager-inl.h 82.97% <0.00%> (-6.39%) ⬇️
src/storage/mutate/AddVerticesProcessor.cpp 83.25% <0.00%> (-4.79%) ⬇️
src/storage/exec/FilterNode.h 92.00% <0.00%> (-4.00%) ⬇️
src/storage/mutate/AddEdgesProcessor.cpp 56.66% <0.00%> (-3.67%) ⬇️
src/common/base/Status.h 88.63% <0.00%> (-2.28%) ⬇️
src/storage/exec/TagNode.h 93.61% <0.00%> (-2.13%) ⬇️
src/clients/storage/StorageClientBase-inl.h 78.61% <0.00%> (-1.85%) ⬇️
src/storage/exec/QueryUtils.h 91.42% <0.00%> (-1.78%) ⬇️
src/common/expression/LogicalExpression.cpp 91.66% <0.00%> (-1.73%) ⬇️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a101981...985fc24. Read the comment docs.

@CPWstatic CPWstatic merged commit b4af65a into vesoft-inc:master Nov 3, 2021
@Aiee Aiee deleted the fix-pr-template branch November 3, 2021 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants