Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build ARM platform docker images #3240

Merged
merged 4 commits into from
Nov 1, 2021

Conversation

yixinglu
Copy link
Contributor

@yixinglu yixinglu commented Oct 31, 2021

What type of PR is this?

  • bug
  • feature

Which issue(s) this PR fixes:

close #2834
close #2656
(If it is requirement, issue(s) number must be listed.)

What this PR does / why we need it?

Special notes for your reviewer, ex. impact of this fix, etc:

Additional context:

Checklist:

  • Documentation affected (If need to modify document, please label it.)
  • Incompatible (If it is incompatile, please describle it and label it.)
  • Need to cherry pick (If need to cherry pick to some branchs, please label the destination version(s).)
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory

Release notes:

Please confirm whether to reflect in release notes and how to describe:
`

Depends PRs:

vesoft-inc/nebula-dev-docker#58

@yixinglu yixinglu added ready-for-testing PR: ready for the CI test doc affected PR: improvements or additions to documentation labels Nov 1, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #3240 (5cad44f) into master (a101981) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3240   +/-   ##
=======================================
  Coverage   85.26%   85.26%           
=======================================
  Files        1295     1295           
  Lines      118177   118185    +8     
=======================================
+ Hits       100758   100775   +17     
+ Misses      17419    17410    -9     
Impacted Files Coverage Δ
src/kvstore/raftex/Host.cpp 63.68% <0.00%> (-5.19%) ⬇️
src/storage/exec/FilterNode.h 92.00% <0.00%> (-4.00%) ⬇️
src/storage/mutate/AddEdgesProcessor.cpp 57.66% <0.00%> (-2.67%) ⬇️
src/storage/exec/TagNode.h 93.61% <0.00%> (-2.13%) ⬇️
src/storage/exec/QueryUtils.h 91.42% <0.00%> (-1.78%) ⬇️
src/kvstore/raftex/test/RaftCase.cpp 69.71% <0.00%> (-1.41%) ⬇️
src/common/fs/FileUtils.cpp 74.66% <0.00%> (-1.36%) ⬇️
src/clients/storage/StorageClientBase-inl.h 79.19% <0.00%> (-1.27%) ⬇️
src/codec/RowReaderV2.cpp 94.06% <0.00%> (-0.81%) ⬇️
src/graph/service/GraphService.cpp 74.01% <0.00%> (-0.79%) ⬇️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a101981...5cad44f. Read the comment docs.

Copy link
Contributor

@wey-gu wey-gu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Great Job!

@yixinglu yixinglu merged commit 5acce45 into vesoft-inc:master Nov 1, 2021
@yixinglu yixinglu deleted the support-arm-platform branch November 1, 2021 07:34
@wey-gu
Copy link
Contributor

wey-gu commented Nov 1, 2021

Looking forward to the next nightly build!!!!

@wey-gu
Copy link
Contributor

wey-gu commented Nov 2, 2021

https://github.com/vesoft-inc/nebula/runs/4071193719?check_suite_focus=true

------
 > [linux/arm64 builder 3/3] RUN cd /home/nebula/BUILD/package   && ./package.sh -n OFF -b master -t RelWithDebInfo -s TRUE:
#15 1.671 strip_enable: TRUE
#15 1.671 enablesanitizer: OFF
#15 1.671 static_sanitizer: OFF
#15 1.671 build_type: RelWithDebInfo
#15 1.671 branch: master
#15 1.671 enable_compressed_debug_info: ON
#15 1.671 dump_symbols: OFF
#15 1.671 
#15 1.739 /home/nebula/BUILD/pkg-build /home/nebula/BUILD/package
#15 1.747 ./package.sh: /opt/vesoft/toolset/cmake/bin/cmake: /lib64/ld-linux-x86-64.so.2: bad ELF interpreter: No such file or directory
------
Dockerfile.graphd:7
--------------------
   6 |     
   7 | >>> RUN cd /home/nebula/BUILD/package \
   8 | >>>   && ./package.sh -n OFF -b ${BRANCH} -t RelWithDebInfo -s TRUE
   9 |     
--------------------
error: failed to solve: process "/bin/bash -c cd /home/nebula/BUILD/package   && ./package.sh -n OFF -b ${BRANCH} -t RelWithDebInfo -s TRUE" did not complete successfully: exit code: 126
Error: buildx failed with: error: failed to solve: process "/bin/bash -c cd /home/nebula/BUILD/package   && ./package.sh -n OFF -b ${BRANCH} -t RelWithDebInfo -s TRUE" did not complete successfully: exit code: 126

yixinglu added a commit to yixinglu/nebula that referenced this pull request Nov 2, 2021
* Build docker image for arm64 platform

* Fix shell check error in GitHub action runner

* build arm platform image nightly

* Cleanup v2-nightly image
yixinglu added a commit that referenced this pull request Nov 3, 2021
* Build ARM platform docker images (#3240)

* Build docker image for arm64 platform

* Fix shell check error in GitHub action runner

* build arm platform image nightly

* Cleanup v2-nightly image

* disable lookup yield agg function (#3245)

* disable lookup yield agg function

* add ci case

Co-authored-by: jimingquan <mingquan.ji@vesoft.com>
@abby-cyber
Copy link
Contributor

#3618

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc affected PR: improvements or additions to documentation ready-for-testing PR: ready for the CI test
Projects
Development

Successfully merging this pull request may close these issues.

Error connecting nebula with console on M1 Add ARM action runner
5 participants