Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add license check #3268

Merged
merged 4 commits into from
Nov 5, 2021
Merged

Add license check #3268

merged 4 commits into from
Nov 5, 2021

Conversation

heyanlong
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What does this PR do?

Add license check

Which issue(s)/PR(s) this PR relates to?

None

@CLAassistant
Copy link

CLAassistant commented Nov 4, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@yixinglu yixinglu added the ready-for-testing PR: ready for the CI test label Nov 4, 2021
yixinglu
yixinglu previously approved these changes Nov 4, 2021
View reviewed changes
Copy link
Contributor

@yixinglu yixinglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Shylock-Hg
Copy link
Contributor

Run in CI?

@heyanlong
Copy link
Contributor Author

Request CI

Shylock-Hg
Shylock-Hg previously approved these changes Nov 4, 2021
View reviewed changes
@heyanlong
Copy link
Contributor Author

Ignore the license verification of cmake, conf, tests, and docker for now, and you can open it if necessary

@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2021 •
edited
Loading

Codecov Report

Merging #3268 (002b3c3) into master (07ccfde) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3268      +/-   ##
==========================================
- Coverage   85.25%   85.24%   -0.01%     
==========================================
  Files        1295     1295              
  Lines      118193   118201       +8     
==========================================
+ Hits       100760   100763       +3     
- Misses      17433    17438       +5
Impacted Files Coverage Δ
src/common/datatypes/EdgeOps-inl.h 47.16% <ø> (ø)
src/common/datatypes/HostAddrOps-inl.h 78.37% <ø> (ø)
src/common/datatypes/PathOps-inl.h 52.26% <ø> (ø)
src/common/datatypes/ValueOps-inl.h 61.49% <ø> (+0.20%) ⬆️
src/common/geo/GeoIndex.cpp 80.72% <ø> (ø)
src/meta/processors/parts/GetSpaceProcessor.cpp 60.60% <0.00%> (-18.19%) ⬇️
src/graph/executor/StorageAccessExecutor.h 66.66% <0.00%> (-11.54%) ⬇️
src/common/thrift/ThriftClientManager-inl.h 82.97% <0.00%> (-6.39%) ⬇️
...eta/processors/session/SessionManagerProcessor.cpp 74.19% <0.00%> (-4.52%) ⬇️
src/graph/executor/query/IndexScanExecutor.cpp 88.88% <0.00%> (-2.54%) ⬇️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07ccfde...002b3c3. Read the comment docs.

@heyanlong
Copy link
Contributor Author

Need fix build error for self-hosted

@yixinglu yixinglu merged commit 22a5fe9 into vesoft-inc:master Nov 5, 2021
@jamieliu1023 jamieliu1023 mentioned this pull request Nov 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yixinglu yixinglu yixinglu approved these changes

@Aiee Aiee Aiee approved these changes

@jievince jievince Awaiting requested review from jievince

@jamieliu1023 jamieliu1023 Awaiting requested review from jamieliu1023

@Shylock-Hg Shylock-Hg Awaiting requested review from Shylock-Hg

Assignees
No one assigned
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@heyanlong @CLAassistant @Shylock-Hg @codecov-commenter @yixinglu @Aiee