Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trigger packaging action when pushing release branch #3283

Merged
merged 4 commits into from
Nov 18, 2021
Merged

Trigger packaging action when pushing release branch #3283

merged 4 commits into from
Nov 18, 2021

Conversation

yixinglu
Copy link
Contributor

@yixinglu yixinglu commented Nov 8, 2021

Don't package when publishing a release.

@yixinglu yixinglu force-pushed the package-every-push-release-branch branch from 73fe02f to e51133e Compare November 18, 2021 06:26
@yixinglu yixinglu force-pushed the package-every-push-release-branch branch from 5595d98 to 4b1a030 Compare November 18, 2021 08:08
@yixinglu yixinglu added the ready-for-testing PR: ready for the CI test label Nov 18, 2021
@yixinglu yixinglu mentioned this pull request Nov 18, 2021
Merged
Sophie-Xie
Sophie-Xie previously approved these changes Nov 18, 2021
View reviewed changes
Copy link
Contributor

@Sophie-Xie Sophie-Xie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

Shinji-IkariG
Shinji-IkariG previously approved these changes Nov 18, 2021
View reviewed changes
Copy link
Contributor

@Shinji-IkariG Shinji-IkariG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2021 •
edited

Codecov Report

Merging #3283 (0116e3a) into master (07d5e21) will increase coverage by 0.01%.
The diff coverage is 79.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3283      +/-   ##
==========================================
+ Coverage   85.23%   85.25%   +0.01%     
==========================================
  Files        1289     1289              
  Lines      119974   119978       +4     
==========================================
+ Hits       102265   102283      +18     
+ Misses      17709    17695      -14
Impacted Files Coverage Δ
src/clients/meta/MetaClient.h 95.65% <ø> (ø)
src/clients/storage/GraphStorageClient.cpp 73.29% <ø> (+0.18%) ⬆️
src/clients/storage/StorageClientBase.h 65.57% <ø> (ø)
src/codec/RowReaderV1.cpp 71.22% <ø> (ø)
src/codec/RowReaderV1.h 100.00% <ø> (ø)
src/codec/RowWriterV2.h 94.44% <ø> (ø)
src/codec/test/RowReaderBenchmark.cpp 68.75% <ø> (ø)
src/common/base/ConcurrentLRUCache.h 100.00% <ø> (ø)
src/common/base/SignalHandler.h 83.33% <ø> (ø)
src/common/base/Status.h 90.90% <ø> (+2.27%) ⬆️
... and 231 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7feb32...0116e3a. Read the comment docs.

@yixinglu yixinglu merged commit 21582a1 into vesoft-inc:master Nov 18, 2021
@yixinglu yixinglu deleted the package-every-push-release-branch branch November 18, 2021 11:51
@jamieliu1023 jamieliu1023 mentioned this pull request Nov 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarrisChu HarrisChu HarrisChu approved these changes

@Sophie-Xie Sophie-Xie Sophie-Xie approved these changes

@Shinji-IkariG Shinji-IkariG Shinji-IkariG left review comments

@CPWstatic CPWstatic Awaiting requested review from CPWstatic

Assignees
No one assigned
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@yixinglu @codecov-commenter @HarrisChu @Shinji-IkariG @Sophie-Xie