Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nebula-python installation in the test #3290

Merged
merged 2 commits into from
Nov 9, 2021

Conversation

Aiee
Copy link
Contributor

@Aiee Aiee commented Nov 9, 2021

What type of PR is this?

  • bug
  • feature
  • enhancement

What does this PR do?

Update nebula-python installation in the test due to the change made in vesoft-inc/nebula-python#153

Which issue(s)/PR(s) this PR relates to?

vesoft-inc/nebula-python#153

Special notes for your reviewer, ex. impact of this fix, etc:

Additional context:

Checklist:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatible (If it is incompatible, please describe it and add corresponding label.)
  • Need to cherry-pick (If need to cherry-pick to some branches, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to reflect in release notes and how to describe:

                                                            `

@Aiee Aiee added the ready-for-testing PR: ready for the CI test label Nov 9, 2021
tests/Makefile Outdated Show resolved Hide resolved
@Aiee Aiee requested a review from Shylock-Hg November 9, 2021 07:17
@codecov-commenter
Copy link

Codecov Report

Merging #3290 (a3250b9) into master (219d000) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3290      +/-   ##
==========================================
- Coverage   85.34%   85.31%   -0.03%     
==========================================
  Files        1304     1304              
  Lines      119910   119918       +8     
==========================================
- Hits       102332   102312      -20     
- Misses      17578    17606      +28     
Impacted Files Coverage Δ
src/graph/context/Result.cpp 85.00% <0.00%> (-10.00%) ⬇️
src/kvstore/raftex/Host.cpp 63.68% <0.00%> (-5.19%) ⬇️
src/graph/planner/Planner.cpp 75.00% <0.00%> (-5.00%) ⬇️
...eta/processors/session/SessionManagerProcessor.cpp 74.19% <0.00%> (-4.52%) ⬇️
src/common/thread/GenericWorker.h 92.30% <0.00%> (-3.85%) ⬇️
src/graph/service/PermissionCheck.cpp 78.72% <0.00%> (-2.13%) ⬇️
src/storage/exec/QueryUtils.h 91.42% <0.00%> (-1.78%) ⬇️
src/common/expression/LogicalExpression.cpp 91.66% <0.00%> (-1.73%) ⬇️
src/graph/session/GraphSessionManager.cpp 79.88% <0.00%> (-1.15%) ⬇️
src/kvstore/wal/test/AtomicLogBufferTest.cpp 94.73% <0.00%> (-1.06%) ⬇️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 219d000...a3250b9. Read the comment docs.

@yixinglu yixinglu merged commit f682359 into vesoft-inc:master Nov 9, 2021
@Aiee Aiee deleted the update-workflow branch November 9, 2021 10:02
Sophie-Xie pushed a commit that referenced this pull request Dec 2, 2021
* Update nebula-python installation

* Add --user to pip install
yixinglu pushed a commit that referenced this pull request Dec 2, 2021
* Update nebula-python installation

* Add --user to pip install

Co-authored-by: Yichen Wang <18348405+Aiee@users.noreply.github.com>
Sophie-Xie pushed a commit that referenced this pull request Dec 3, 2021
* Update nebula-python installation

* Add --user to pip install
critical27 pushed a commit that referenced this pull request Dec 3, 2021
* Update nebula-python installation

* Add --user to pip install

Co-authored-by: Yichen Wang <18348405+Aiee@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants