Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling #3297

Merged
merged 254 commits into from
Nov 18, 2021
Merged

Spelling #3297

merged 254 commits into from
Nov 18, 2021

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Nov 10, 2021

What type of PR is this?

  • bug
  • feature
  • enhancement

What does this PR do?

This PR corrects misspellings identified by the check-spelling action.

The misspellings have been reported at jsoref@a65eeee#commitcomment-59912745

Which issue(s)/PR(s) this PR relates to?

Special notes for your reviewer, ex. impact of this fix, etc:

I expect to adjust the PR based on project preferences.

Also, CI is currently broken in various ways.

Additional context:

The action reports that the changes in this PR would make it happy: jsoref@4fbd464

Note: this PR does not include the action. If you're interested in running a spell check on every PR and push, that can be offered separately.

Checklist:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatible (If it is incompatible, please describe it and add corresponding label.)
  • Need to cherry-pick (If need to cherry-pick to some branches, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to reflect in release notes and how to describe:

As is, it's quite possible that this results in behavior breaks

@jsoref
Copy link
Contributor Author

jsoref commented Nov 15, 2021

I suspect I need to do something to tim duncan / shaq, but I'm not sure offhand what. Is there someone who could talk me through adjusting this?

I'm tempted to drop those changes and visit them separately...

@czpmango
Copy link
Contributor

I suspect I need to do something to tim duncan / shaq, but I'm not sure offhand what. Is there someone who could talk me through adjusting this?

I'm tempted to drop those changes and visit them separately...

You just missed a ] symbol on line 246 of file subgraph.feature.

This was referenced Nov 16, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2021

Codecov Report

Merging #3297 (e01d59c) into master (07d5e21) will increase coverage by 0.00%.
The diff coverage is 78.20%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3297   +/-   ##
=======================================
  Coverage   85.23%   85.24%           
=======================================
  Files        1289     1289           
  Lines      119974   119973    -1     
=======================================
  Hits       102265   102265           
+ Misses      17709    17708    -1     
Impacted Files Coverage Δ
src/clients/meta/MetaClient.h 95.65% <ø> (ø)
src/clients/storage/GraphStorageClient.cpp 73.29% <ø> (+0.18%) ⬆️
src/clients/storage/StorageClientBase.h 65.57% <ø> (ø)
src/codec/RowReaderV1.cpp 71.22% <ø> (ø)
src/codec/RowReaderV1.h 100.00% <ø> (ø)
src/codec/RowWriterV2.h 94.44% <ø> (ø)
src/codec/test/RowReaderBenchmark.cpp 68.75% <ø> (ø)
src/common/base/ConcurrentLRUCache.h 100.00% <ø> (ø)
src/common/base/SignalHandler.h 83.33% <ø> (ø)
src/common/base/Status.h 88.63% <ø> (ø)
... and 228 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d548db...e01d59c. Read the comment docs.

@czpmango czpmango mentioned this pull request Nov 18, 2021
@CPWstatic
Copy link
Contributor

Super helpful! Please fix the conflicts.

@yixinglu yixinglu merged commit a7feb32 into vesoft-inc:master Nov 18, 2021
@jsoref jsoref mentioned this pull request Nov 18, 2021
7 tasks
@foesa-yang foesa-yang removed the doc affected PR: improvements or additions to documentation label Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Source: who proposed the issue incompatible PR: incompatible with the recently released version ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants